> On March 24, 2016, 2:53 p.m., Kai Uwe Broulik wrote: > > src/pulseaudio.h, line 100 > > <https://git.reviewboard.kde.org/r/127484/diff/2/?file=453889#file453889line100> > > > > You don't actually use the sources, rather have a "count" property?
I copied it from SinkModel::sinks(), just for the consistency. In this case only the count is used, but I think it doesn't hurt (as the model doesn't really changes often) and may be useful in future? - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127484/#review93930 ----------------------------------------------------------- On March 24, 2016, 2:28 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127484/ > ----------------------------------------------------------- > > (Updated March 24, 2016, 2:28 p.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-pa > > > Description > ------- > > Applet now have two tabs: Devices and Streams. > If there are more audo devices, streams can be moved between them with > combobox that is visible after clicking on stream item. > > BUG: 352042 > BUG: 353232 > > > Diffs > ----- > > applet/contents/ui/ListItemBase.qml 2e31eeb > applet/contents/ui/SinkInputListItem.qml 3867007 > applet/contents/ui/SourceOutputListItem.qml 3b684fc > applet/contents/ui/StreamListItemBase.qml 7c0af12 > applet/contents/ui/main.qml bf6f683 > src/pulseaudio.h 9fc9656 > src/pulseaudio.cpp 1488784 > > Diff: https://git.reviewboard.kde.org/r/127484/diff/ > > > Testing > ------- > > Everything seems to work fine. > > > File Attachments > ---------------- > > applet-devices.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/d1f444cd-c69b-4888-a0c0-24bc4b6b8904__applet-devices.png > applet-streams.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/30a3cdfb-b6b5-41c7-bb15-37c6b87604a4__applet-streams.png > applet-streams-more-devices.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/82f0eb13-95a5-4d0c-b50b-682cf7c3b384__applet-streams-more-devices.png > applet-streams-more-devices.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/b2dafc91-4bde-42dc-bfd5-036ee001b984__applet-streams-more-devices.png > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
