> On March 24, 2016, 4:53 p.m., Thomas Pfeiffer wrote:
> > Great that you're bringing streams back to the applet, much appreciated!
> > 
> > I agree with Kai that we should hide the technical stream names, they are 
> > of no use to anybody not deeply interested in PulseAudio. If an application 
> > has more than one stream, it only makes sense to show anything besides the 
> > applicaiton name if it has any meaning for the user. Distinguishing 
> > multiple streams based on some purely technical identifier gives zero 
> > useful information. If we have no human-readable information to distinguish 
> > streams from the same application, we might as well fall back to simply 
> > numbering them.
> > 
> > As for the redirection of streams to devices: What I'd like to see from a 
> > user perspective is simply dragging and dropping. So users could grab a 
> > stream, drag it over to the devices tab and then drop it on a device. That 
> > would be kind of intuitive and wouldn't clutter the UI with dropdown 
> > arrows. I don't know if that is technically feasible, of course.
> 
> David Rosca wrote:
>     > I agree with Kai that we should hide the technical stream names, they 
> are of no use to anybody not deeply interested in PulseAudio....
>     
>     Alright, but that's for another patch. Currently it only shows name that 
> exposes model.
>     
>     > As for the redirection of streams to devices: What I'd like to see from 
> a user perspective is simply dragging and dropping. So users could grab a 
> stream, drag it over to the devices tab and then drop it on a device. That 
> would be kind of intuitive and wouldn't clutter the UI with dropdown arrows. 
> I don't know if that is technically feasible, of course.
>     
>     It is possible, but as the streams are now displayed in separate tab, I 
> think it would be extra awkward. First you will need to change the tab by 
> dragging the stream on the "Devices" tab and then you'll need to find the 
> right device. As the systemtray popup is small, if you have more devices then 
> you would need to also scroll the view.
>     It is also much faster with the combobox than dragging.
>     
>     In other applets (print, network, bluetooth, ..), we already have the 
> pattern of showing additional options when clicking on item. So maybe remove 
> the arrow and indicate the additional actions with hover highlight (as in 
> network applet)?
>     
>     Oh and also currently there is issue with scrolling of the view with 
> mouse wheel that will be interrupted by volume sliders (or even may 
> accidentally change volume). So I'm thinking of completely disabling 
> scrolling with mouse wheel (as there doesn't seem to be better fix while 
> having the option to change volume with wheel on sliders), which would make 
> the scrollbar and flick with left mouse the only way to scroll it. And that 
> would make the dragging impossible.

> In other applets (print, network, bluetooth, ..), we already have the pattern 
> of showing additional options when clicking on item. So maybe remove the 
> arrow and indicate the additional actions with hover highlight (as in network 
> applet)?

Yes, that makes sense!


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127484/#review93937
-----------------------------------------------------------


On March 24, 2016, 2:28 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127484/
> -----------------------------------------------------------
> 
> (Updated March 24, 2016, 2:28 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-pa
> 
> 
> Description
> -------
> 
> Applet now have two tabs: Devices and Streams.
> If there are more audo devices, streams can be moved between them with 
> combobox that is visible after clicking on stream item.
> 
> BUG: 352042
> BUG: 353232
> 
> 
> Diffs
> -----
> 
>   applet/contents/ui/ListItemBase.qml 2e31eeb 
>   applet/contents/ui/SinkInputListItem.qml 3867007 
>   applet/contents/ui/SourceOutputListItem.qml 3b684fc 
>   applet/contents/ui/StreamListItemBase.qml 7c0af12 
>   applet/contents/ui/main.qml bf6f683 
>   src/pulseaudio.h 9fc9656 
>   src/pulseaudio.cpp 1488784 
> 
> Diff: https://git.reviewboard.kde.org/r/127484/diff/
> 
> 
> Testing
> -------
> 
> Everything seems to work fine.
> 
> 
> File Attachments
> ----------------
> 
> applet-devices.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/d1f444cd-c69b-4888-a0c0-24bc4b6b8904__applet-devices.png
> applet-streams.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/30a3cdfb-b6b5-41c7-bb15-37c6b87604a4__applet-streams.png
> applet-streams-more-devices.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/82f0eb13-95a5-4d0c-b50b-682cf7c3b384__applet-streams-more-devices.png
> applet-streams-more-devices.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/b2dafc91-4bde-42dc-bfd5-036ee001b984__applet-streams-more-devices.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to