Re: Review Request 126720: Adds QML's PlasmaCore.SVG CustomColor feature

2017-02-08 Thread Nico Rodsevich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126720/ --- (Updated Feb. 8, 2017, 3:56 p.m.) Status -- This change has been dis

Re: Review Request 126720: Adds QML's PlasmaCore.SVG CustomColor feature

2017-02-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126720/#review102482 --- please post this again on phabricator if is still relevant p

Re: Review Request 126720: Adds QML's PlasmaCore.SVG CustomColor feature

2016-01-12 Thread Marco Martin
> On Jan. 11, 2016, 6:35 p.m., Marco Martin wrote: > > src/plasma/svg.cpp, line 164 > > > > > > coding style: > > void SvgPrivate::updateCustomStyleCrc() > > { > > Nico Rodsevich wrote: > I don't tot

Re: Review Request 126720: Adds QML's PlasmaCore.SVG CustomColor feature

2016-01-12 Thread Marco Martin
On Jan. 12, 2016, 1:19 a.m., Nico Rodsevich wrote: > > Sorry if I missed something, but doesn't this patch makes themes creation > > even harder? :/ yes, pieces with an hardcoded color wouldn't be affected by the color in the themes, so would be to be used with care. that's also why i wanted t

Re: Review Request 126720: Adds QML's PlasmaCore.SVG CustomColor feature

2016-01-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126720/#review90950 --- src/plasma/svg.h (line 119)

Re: Review Request 126720: Adds QML's PlasmaCore.SVG CustomColor feature

2016-01-11 Thread Nico Rodsevich
> On Enero 11, 2016, 6:35 p.m., Marco Martin wrote: > > src/plasma/svg.cpp, line 164 > > > > > > coding style: > > void SvgPrivate::updateCustomStyleCrc() > > { > > Nico Rodsevich wrote: > I don't to

Re: Review Request 126720: Adds QML's PlasmaCore.SVG CustomColor feature

2016-01-11 Thread Marco Martin
> On Jan. 11, 2016, 6:35 p.m., Marco Martin wrote: > > src/plasma/svg.cpp, line 164 > > > > > > coding style: > > void SvgPrivate::updateCustomStyleCrc() > > { > > Nico Rodsevich wrote: > I don't tot

Re: Review Request 126720: Adds QML's PlasmaCore.SVG CustomColor feature

2016-01-11 Thread Nico Rodsevich
> On Enero 11, 2016, 6:35 p.m., Marco Martin wrote: > > src/plasma/svg.cpp, line 164 > > > > > > coding style: > > void SvgPrivate::updateCustomStyleCrc() > > { I don't totally get why QVariantMap is tha

Re: Review Request 126720: Adds QML's PlasmaCore.SVG CustomColor feature

2016-01-11 Thread Marco Martin
> On Jan. 11, 2016, 7:12 p.m., Marco Martin wrote: > > I would do it the following way: > > CustomColorScheme *customColorScheme() const; > > > > > > class CustomColorScheme : public QObject { > > Q_PROPERTY(QColor textColor READ textColor WRITE setTextColor NOTIFY > > textColorChanged) >

Re: Review Request 126720: Adds QML's PlasmaCore.SVG CustomColor feature

2016-01-11 Thread Nico Rodsevich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126720/ --- (Updated Enero 11, 2016, 9:37 p.m.) Review request for Plasma, David Edmu