On Jan. 12, 2016, 1:19 a.m., Nico Rodsevich wrote: > > Sorry if I missed something, but doesn't this patch makes themes creation > > even harder? :/
yes, pieces with an hardcoded color wouldn't be affected by the color in the themes, so would be to be used with care. that's also why i wanted to allow to replace only named colors, and as a guideline only with other named colors, to make things like icons colored in red for errors (there is a value in kcolorscheme for that) in white when in a selected area and so on ( for instance on plasma mobile i would really need to have the icon white when the central action button is pressed/checked) of course the user can screw things up by using hardcoded colors (and i can well see special cases when this is actually desired), but at least in the coding guidelines would be recommended to use bindings to theme colors - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126720/#review90950 ----------------------------------------------------------- On Jan. 11, 2016, 9:37 p.m., Nico Rodsevich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126720/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2016, 9:37 p.m.) > > > Review request for Plasma, David Edmundson and Marco Martin. > > > Repository: plasma-framework > > > Description > ------- > > Enables to set rules that extends the #current-color-scheme CSS style of the > Svg in order to change the Svg's items with currentColor fill to the > specified in the customColors rules > > > Diffs > ----- > > src/plasma/private/svg_p.h 1d1000d > src/plasma/svg.h 3a4ca1d > src/plasma/svg.cpp 28abd00 > > Diff: https://git.reviewboard.kde.org/r/126720/diff/ > > > Testing > ------- > > > Thanks, > > Nico Rodsevich > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
