----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126720/#review90950 -----------------------------------------------------------
src/plasma/svg.h (line 119) <https://git.reviewboard.kde.org/r/126720/#comment62135> Commit separately src/plasma/svg.cpp (line 454) <https://git.reviewboard.kde.org/r/126720/#comment62132> Use const iterators src/plasma/svg.cpp (line 991) <https://git.reviewboard.kde.org/r/126720/#comment62133> const QString & src/plasma/svg.cpp (line 1018) <https://git.reviewboard.kde.org/r/126720/#comment62134> Looks like `emit customColorSchemeChanged(); emit repaintNeeded();` could be called within `d->updateCustomStyleCrc();`. Sorry if I missed something, but doesn't this patch makes themes creation even harder? :/ - Aleix Pol Gonzalez On Jan. 11, 2016, 10:37 p.m., Nico Rodsevich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126720/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2016, 10:37 p.m.) > > > Review request for Plasma, David Edmundson and Marco Martin. > > > Repository: plasma-framework > > > Description > ------- > > Enables to set rules that extends the #current-color-scheme CSS style of the > Svg in order to change the Svg's items with currentColor fill to the > specified in the customColors rules > > > Diffs > ----- > > src/plasma/private/svg_p.h 1d1000d > src/plasma/svg.h 3a4ca1d > src/plasma/svg.cpp 28abd00 > > Diff: https://git.reviewboard.kde.org/r/126720/diff/ > > > Testing > ------- > > > Thanks, > > Nico Rodsevich > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
