Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated June 10, 2015, 4:41 p.m.) Status -- This change has been ma

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80755 --- Ship it! ...in 10 days Great work on all this. - David Edmu

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 21, 2015, 4:02 p.m.) Review request for KDE Frameworks and P

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80695 --- Ship it! Awesome. I love the test! autotests/quickviewshare

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 21, 2015, 10:52 a.m.) Review request for KDE Frameworks and

Re: Review Request 123735: version of QmlObject with a static engine

> On May 20, 2015, 5:24 p.m., Vishesh Handa wrote: > > src/quickaddons/quickviewsharedengine.h, line 41 > > > > > > It would be awesome if we could have some tests for this class. > > > > Maybe we can ju

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80669 --- src/quickaddons/quickviewsharedengine.h (line 41)

Re: Review Request 123735: version of QmlObject with a static engine

> On May 19, 2015, 3:04 p.m., Vishesh Handa wrote: > > src/kdeclarative/qmlobjectsharedengine.cpp, line 60 > > > > > > I'm probably missing some parts of the picture. Could you please > > explain why this needs t

Re: Review Request 123735: version of QmlObject with a static engine

> On May 19, 2015, 3:04 p.m., Vishesh Handa wrote: > > src/kdeclarative/qmlobjectsharedengine.cpp, line 60 > > > > > > I'm probably missing some parts of the picture. Could you please > > explain why this needs t

Re: Review Request 123735: version of QmlObject with a static engine

> On May 19, 2015, 3:04 p.m., Vishesh Handa wrote: > > src/kdeclarative/qmlobjectsharedengine.cpp, line 60 > > > > > > I'm probably missing some parts of the picture. Could you please > > explain why this needs t

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80630 --- src/kdeclarative/qmlobjectsharedengine.cpp (line 41)

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 18, 2015, 8 p.m.) Review request for KDE Frameworks and Plas

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80600 --- src/quickaddons/quickviewsharedengine.cpp (lines 35 - 39)

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 18, 2015, 7:09 p.m.) Review request for KDE Frameworks and P

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 18, 2015, 7:02 p.m.) Review request for KDE Frameworks and P

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 13, 2015, 5:37 p.m.) Review request for KDE Frameworks and P

Re: Review Request 123735: version of QmlObject with a static engine

> On May 12, 2015, 5:45 p.m., Mark Gaiser wrote: > > src/kdeclarative/qmlobjectsharedengine.h, line 57 > > > > > > std::unique_ptr<...> ... > > then you can also forget about the delete in the destructor. buh

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80252 --- src/kdeclarative/qmlobjectsharedengine.h (line 57)

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 12, 2015, 4:12 p.m.) Review request for KDE Frameworks and P

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 12, 2015, 4:10 p.m.) Review request for KDE Frameworks and P

Re: Review Request 123735: version of QmlObject with a static engine

> On May 12, 2015, 3:52 p.m., David Edmundson wrote: > > src/kdeclarative/qmlobjectsharedengine.cpp, line 62 > > > > > > this needs to be initialised. line 65 QQmlEngine *QmlObjectSharedEnginePrivate::s_engine =

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 12, 2015, 4:05 p.m.) Review request for KDE Frameworks and P

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80244 --- src/kdeclarative/qmlobject.cpp (line 176)

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80249 --- src/kdeclarative/qmlobject.h (line 81)

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 12, 2015, 3:35 p.m.) Review request for KDE Frameworks and P

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80241 --- Can you make the diff against the branch root instead of origi

Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative