----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80244 -----------------------------------------------------------
src/kdeclarative/qmlobject.cpp (line 176) <https://git.reviewboard.kde.org/r/123735/#comment55041> if we're using the shared engine we end up not setting the incubation controller. I don't know what difference that will make? src/kdeclarative/qmlobjectsharedengine.cpp (lines 25 - 27) <https://git.reviewboard.kde.org/r/123735/#comment55040> unused src/kdeclarative/qmlobjectsharedengine.cpp (line 62) <https://git.reviewboard.kde.org/r/123735/#comment55039> this needs to be initialised. src/kdeclarative/qmlobjectsharedengine.cpp (line 69) <https://git.reviewboard.kde.org/r/123735/#comment55042> I'm not sure the ownership on the context is right. I think we want the context to last for the lifespan of the QmlObjectSharedEngine (this), currently it's the lifespan of the enitre app - David Edmundson On May 12, 2015, 3:35 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123735/ > ----------------------------------------------------------- > > (Updated May 12, 2015, 3:35 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kdeclarative > > > Description > ------- > > to make easier doing applications like plasma that use a lot of qml to have a > single engine make a subclass of QmlObject called QmlObjectSharedEngine that > has a single, static QQmlEngine > > > Diffs > ----- > > src/kdeclarative/CMakeLists.txt d73bff0 > src/kdeclarative/kdeclarative.cpp b3906e2 > src/kdeclarative/qmlobject.h f26b67d > src/kdeclarative/qmlobject.cpp c483665 > src/kdeclarative/qmlobjectsharedengine.h PRE-CREATION > src/kdeclarative/qmlobjectsharedengine.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/123735/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
