Re: Review Request 115301: Add OSD notifications to plasma-shell

2014-01-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115301/#review48475 --- This review has been submitted with commit 605ab0f130128d0fa1

Re: Review Request 115301: Add OSD notifications to plasma-shell

2014-01-28 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115301/ --- (Updated Jan. 28, 2014, 2:24 p.m.) Status -- This change has been ma

Re: Review Request 115301: Add OSD notifications to plasma-shell

2014-01-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115301/#review48272 --- Ship it! fine for me :) src/shell/shellcorona.cpp

Re: Review Request 115301: Add OSD notifications to plasma-shell

2014-01-25 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115301/#review48271 --- src/shell/osd.h

Re: Review Request 115301: Add OSD notifications to plasma-shell

2014-01-25 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115301/ --- (Updated Jan. 25, 2014, 6:31 p.m.) Review request for Plasma. Changes -

Re: Review Request 115301: Add OSD notifications to plasma-shell

2014-01-24 Thread Marco Martin
> On Jan. 24, 2014, 4:56 p.m., David Edmundson wrote: > > src/shell/osd.cpp, line 118 > > > > > > This seems a bit risky? > > > > Is it relying on the root item being a Plasma.Dialog? > > > > G

Re: Review Request 115301: Add OSD notifications to plasma-shell

2014-01-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115301/#review48233 --- src/shell/osd.cpp

Re: Review Request 115301: Add OSD notifications to plasma-shell

2014-01-24 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115301/#review48235 --- in general is good, just a preliminary review, pointing out so

Review Request 115301: Add OSD notifications to plasma-shell

2014-01-24 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115301/ --- Review request for Plasma. Repository: plasma-framework Description ---