----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115301/#review48272 -----------------------------------------------------------
Ship it! fine for me :) src/shell/shellcorona.cpp <https://git.reviewboard.kde.org/r/115301/#comment34162> I wonder if a shell type should be able to tell that it doesn't want an osd at all(that may eventually be done down the road if there will be the need) - Marco Martin On Jan. 25, 2014, 5:31 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115301/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2014, 5:31 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > As we decided to make the OSD available only for certain things, the API is > intentionally limited to very particular set of things. The list is not > complete yet I believe, but I'd like to get comments on the general design > and state. > > Also as it's not a public service, I left it under org.kde.plasma_shell on > D-Bus. Makes sense? Does not? Should it be standalone at eg. org.kde.osd? > > Note: This still needs patches in kwin. > > > Diffs > ----- > > src/shell/shellcorona.cpp f565d79 > src/shell/osd.cpp PRE-CREATION > src/shell/osd.h PRE-CREATION > src/shell/CMakeLists.txt 5c4b360 > > Diff: https://git.reviewboard.kde.org/r/115301/diff/ > > > Testing > ------- > > Can be invoked using qdbus from command line. Works rather well. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
