----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115301/#review48235 -----------------------------------------------------------
in general is good, just a preliminary review, pointing out some things i find may be improved src/shell/osd.h <https://git.reviewboard.kde.org/r/115301/#comment34121> Even if it's an acronym, since QUrl is not QURL, should this be Osd? src/shell/osd.h <https://git.reviewboard.kde.org/r/115301/#comment34119> in the end was rename to lookAndFeelpackage it should anyways get a pointr to Corona instead? (so it can watch for changed) src/shell/shellmanager.cpp <https://git.reviewboard.kde.org/r/115301/#comment34120> instead of being here, should probably be in the corona ctor, so could be just new OSD(this); with this being the corona, used as parent as well - Marco Martin On Jan. 24, 2014, 4:40 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115301/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2014, 4:40 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > As we decided to make the OSD available only for certain things, the API is > intentionally limited to very particular set of things. The list is not > complete yet I believe, but I'd like to get comments on the general design > and state. > > Also as it's not a public service, I left it under org.kde.plasma_shell on > D-Bus. Makes sense? Does not? Should it be standalone at eg. org.kde.osd? > > Note: This still needs patches in kwin. > > > Diffs > ----- > > src/shell/shellmanager.cpp 1188b48 > src/shell/osd.cpp PRE-CREATION > src/shell/osd.h PRE-CREATION > src/shell/CMakeLists.txt 5c4b360 > > Diff: https://git.reviewboard.kde.org/r/115301/diff/ > > > Testing > ------- > > Can be invoked using qdbus from command line. Works rather well. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
