Re: Review Request 114149: Fix plasma on multiple monitors

2013-11-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114149/#review44694 --- This review has been submitted with commit 9462866755c4ab1ae42

Re: Review Request 114149: Fix plasma on multiple monitors

2013-11-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114149/ --- (Updated Nov. 28, 2013, 1:46 p.m.) Status -- This change has been mar

Re: Review Request 114149: Fix plasma on multiple monitors

2013-11-28 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114149/#review44692 --- Ship it! > The only solution is to cast it so the compiler kno

Re: Review Request 114149: Fix plasma on multiple monitors

2013-11-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114149/ --- (Updated Nov. 28, 2013, 12:16 p.m.) Review request for Plasma. Changes -

Re: Review Request 114149: Fix plasma on multiple monitors

2013-11-27 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114149/#review44579 --- Ship it! Tested and confirmed working here. Once Martin's hap

Re: Review Request 114149: Fix plasma on multiple monitors

2013-11-27 Thread Martin Gräßlin
> On Nov. 27, 2013, 2:02 p.m., Martin Gräßlin wrote: > > src/shell/desktopview.cpp, lines 144-147 > > > > > > why did you introduce this new slot? It looks to me like you could just > > connet to setGeometry dire

Re: Review Request 114149: Fix plasma on multiple monitors

2013-11-27 Thread David Edmundson
> On Nov. 27, 2013, 1:02 p.m., Martin Gräßlin wrote: > > src/shell/desktopview.cpp, lines 144-147 > > > > > > why did you introduce this new slot? It looks to me like you could just > > connet to setGeometry dire

Re: Review Request 114149: Fix plasma on multiple monitors

2013-11-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114149/#review44567 --- src/shell/desktopview.cpp

Review Request 114149: Fix plasma on multiple monitors

2013-11-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114149/ --- Review request for Plasma. Repository: plasma-framework Description