----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114149/#review44567 -----------------------------------------------------------
src/shell/desktopview.cpp <http://git.reviewboard.kde.org/r/114149/#comment31815> why did you introduce this new slot? It looks to me like you could just connet to setGeometry directly? src/shell/shellcorona.cpp <http://git.reviewboard.kde.org/r/114149/#comment31817> any specific reason why you use Q_FOREACH and not the new for-syntax? for (QScreen *screen : QGuiApplications::screen()) I prefer the new for syntax as it's not a macro and also works with multiple templates and is not YELLING ;-) src/shell/shellcorona.cpp <http://git.reviewboard.kde.org/r/114149/#comment31816> suggestion: for (auto i = d->views.begin(); i != d->views.end(); i++) { // if-condition as is } - Martin Gräßlin On Nov. 27, 2013, 12:34 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114149/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2013, 12:34 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Set geometry to fill each screen correctly > > DesktopView incorrectly filled the geometry of screen() > screen() will be the screen of the parent shell, not the correct > screen. > > As we were already part-using QScreen, shellcorona is ported to use that > instead > of QDesktopWidget, so we can keep track of which screen is actually removed > instead of just assuming it was the last one. > > > Diffs > ----- > > src/shell/desktopview.h b8b9caa > src/shell/desktopview.cpp 90a5730 > src/shell/shellcorona.h ee5e2bc > src/shell/shellcorona.cpp ef6fbe2 > > Diff: http://git.reviewboard.kde.org/r/114149/diff/ > > > Testing > ------- > > Used two monitors, and I now have a different wallpaper on each \o/ > > There's a crash on unplugging a monitor, this happens before my patch and > appears to be unrelated. > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
