----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114149/#review44692 -----------------------------------------------------------
Ship it! > The only solution is to cast it so the compiler knows which function you > meant. yeah, that's the normal solution for overloaded methods (no matter whether slots or not). It's not the most beautiful code but still nicer that what we had before IMHO. - Martin Gräßlin On Nov. 28, 2013, 1:16 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114149/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2013, 1:16 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Set geometry to fill each screen correctly > > DesktopView incorrectly filled the geometry of screen() > screen() will be the screen of the parent shell, not the correct > screen. > > As we were already part-using QScreen, shellcorona is ported to use that > instead > of QDesktopWidget, so we can keep track of which screen is actually removed > instead of just assuming it was the last one. > > > Diffs > ----- > > src/shell/desktopview.h b8b9caa > src/shell/desktopview.cpp 90a5730 > src/shell/shellcorona.h ee5e2bc > src/shell/shellcorona.cpp ef6fbe2 > > Diff: http://git.reviewboard.kde.org/r/114149/diff/ > > > Testing > ------- > > Used two monitors, and I now have a different wallpaper on each \o/ > > There's a crash on unplugging a monitor, this happens before my patch and > appears to be unrelated. > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
