Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108643/#review26403 --- This review has been submitted with commit 677beae1ecc3c15fdc5

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108643/#review26402 --- This review has been submitted with commit 7f48bf01b3092f9232b

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108643/#review26401 --- This review has been submitted with commit 677beae1ecc3c15fdc5

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108643/#review26372 --- Ship it! Please revert the forceActiveWindow call to activateW

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

> On Jan. 28, 2013, 3:30 p.m., Thomas Lübking wrote: > > What kinda strucks me is that the window is translucent for the > > Qt::transparent. > > This also requires it to be 32bit, ie. ARGB - is that lockerwindow > > constructed out of sth. else here (eg. plasma-desktop) or do you eventually >

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

> On Jan. 28, 2013, 3:27 p.m., Thomas Lübking wrote: > > ksmserver/screenlocker/greeter/greeterapp.cpp, line 210 > > > > > > This is pointless because the greeter view is not managed > > ("view->setWindowFlags(Qt

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

> On Jan. 28, 2013, 4:44 p.m., Oliver Henshaw wrote: > > This going to be a patch series, isn't it? There looks like there's a few > > things lumped together in this patch (port from kephal, change from > > transparent to black, removal of legacy code snippet, the geometry change > > fix, the

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108643/#review26318 --- This going to be a patch series, isn't it? There looks like the

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

> On Jan. 28, 2013, 3:30 p.m., Thomas Lübking wrote: > > What kinda strucks me is that the window is translucent for the > > Qt::transparent. > > This also requires it to be 32bit, ie. ARGB - is that lockerwindow > > constructed out of sth. else here (eg. plasma-desktop) or do you eventually >

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

> On Jan. 28, 2013, 3:27 p.m., Thomas Lübking wrote: > > ksmserver/screenlocker/greeter/greeterapp.cpp, line 210 > > > > > > This is pointless because the greeter view is not managed > > ("view->setWindowFlags(Qt

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

> On Jan. 28, 2013, 3:30 p.m., Thomas Lübking wrote: > > What kinda strucks me is that the window is translucent for the > > Qt::transparent. > > This also requires it to be 32bit, ie. ARGB - is that lockerwindow > > constructed out of sth. else here (eg. plasma-desktop) or do you eventually >

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108643/#review26314 --- What kinda strucks me is that the window is translucent for the

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108643/#review26313 --- ksmserver/screenlocker/greeter/greeterapp.cpp

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108643/ --- (Updated Jan. 28, 2013, 2:38 p.m.) Review request for kwin, Plasma, Martin

Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108643/ --- Review request for kwin, Plasma, Martin Gräßlin, and Thomas Lübking. Descr