> On Jan. 28, 2013, 3:27 p.m., Thomas Lübking wrote: > > ksmserver/screenlocker/greeter/greeterapp.cpp, line 210 > > <http://git.reviewboard.kde.org/r/108643/diff/1/?file=109632#file109632line210> > > > > This is pointless because the greeter view is not managed > > ("view->setWindowFlags(Qt::X11BypassWindowManagerHint);") > > > > Internal activation will be required to get the focus, kwin won't set > > it. > > > > The additional raise might be required on top (if the lockerwindow > > moved itself above the greeter) - at least activateWindow will not raise > > the window. > > Aaron J. Seigo wrote: > this was in the original patch, so i simply left it there. can easily be > removed.
from RR 108585? (it's not in the RB diff) The thing i posted at the greeter bug is only to document the local alteration at that time (experimented with a managed window because of the focus thing - it's not an option though unless we rely on a NETWM compliant WM) - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108643/#review26313 ----------------------------------------------------------- On Jan. 28, 2013, 2:38 p.m., Aaron J. Seigo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108643/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2013, 2:38 p.m.) > > > Review request for kwin, Plasma, Martin Gräßlin, and Thomas Lübking. > > > Description > ------- > > Updated version of Thomas' patch from > https://git.reviewboard.kde.org/r/108585/ > > Tested and works in the use case originally noted as broken, and as a bonus > includes getting rid of usage of libkephal. > > > This addresses bug 313835. > http://bugs.kde.org/show_bug.cgi?id=313835 > > > Diffs > ----- > > ksmserver/screenlocker/CMakeLists.txt > bab32eda33526bbe5149bc903fbb6a28fb9d28d7 > ksmserver/screenlocker/greeter/CMakeLists.txt > f89a98d66b774d00bbe8b881c66298ed7e339dac > ksmserver/screenlocker/greeter/greeterapp.cpp > b41cc74ce4f072610772366be3abdf1f4f25f24e > ksmserver/screenlocker/lockwindow.h > 5cbc76956a4b83d46da96a7ef768116ffdd505c3 > ksmserver/screenlocker/lockwindow.cpp > 147853b5625277a35bf01247366c6597636c638c > > Diff: http://git.reviewboard.kde.org/r/108643/diff/ > > > Testing > ------- > > start locker when internal laptop screen is on > plug in external screen > kscreen automagically switches it on and the laptop screen off > locker displays properly > > > Thanks, > > Aaron J. Seigo > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
