> On Jan. 28, 2013, 3:30 p.m., Thomas Lübking wrote: > > What kinda strucks me is that the window is translucent for the > > Qt::transparent. > > This also requires it to be 32bit, ie. ARGB - is that lockerwindow > > constructed out of sth. else here (eg. plasma-desktop) or do you eventually > > run into this with the oxygen-transparent style or the resp. settings of > > QtCurve or Bespin?
yes, that's also true: it probably doesn't need to be translucent. or rather, shouldn't be because we actively do *not* want content visible through it. this could be a hold-over from prior incarnations of the system. feel free to take the changes in this patch and make more changes :) - Aaron J. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108643/#review26314 ----------------------------------------------------------- On Jan. 28, 2013, 2:38 p.m., Aaron J. Seigo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108643/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2013, 2:38 p.m.) > > > Review request for kwin, Plasma, Martin Gräßlin, and Thomas Lübking. > > > Description > ------- > > Updated version of Thomas' patch from > https://git.reviewboard.kde.org/r/108585/ > > Tested and works in the use case originally noted as broken, and as a bonus > includes getting rid of usage of libkephal. > > > This addresses bug 313835. > http://bugs.kde.org/show_bug.cgi?id=313835 > > > Diffs > ----- > > ksmserver/screenlocker/CMakeLists.txt > bab32eda33526bbe5149bc903fbb6a28fb9d28d7 > ksmserver/screenlocker/greeter/CMakeLists.txt > f89a98d66b774d00bbe8b881c66298ed7e339dac > ksmserver/screenlocker/greeter/greeterapp.cpp > b41cc74ce4f072610772366be3abdf1f4f25f24e > ksmserver/screenlocker/lockwindow.h > 5cbc76956a4b83d46da96a7ef768116ffdd505c3 > ksmserver/screenlocker/lockwindow.cpp > 147853b5625277a35bf01247366c6597636c638c > > Diff: http://git.reviewboard.kde.org/r/108643/diff/ > > > Testing > ------- > > start locker when internal laptop screen is on > plug in external screen > kscreen automagically switches it on and the laptop screen off > locker displays properly > > > Thanks, > > Aaron J. Seigo > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
