Re: Review Request: TaskManager: TaskAction changes from IconTasks

2011-11-03 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103004/#review7890 --- Ship it! great :) once this and the other patches are in, we c

Re: Review Request: TaskManager: TaskAction changes from IconTasks

2011-11-02 Thread Craig Drummond
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103004/ --- (Updated Nov. 2, 2011, 10:46 p.m.) Review request for Plasma. Changes --

Re: Review Request: TaskManager: TaskAction changes from IconTasks

2011-11-02 Thread Aaron J. Seigo
> On Nov. 1, 2011, 2:05 p.m., Aaron J. Seigo wrote: > > libs/taskmanager/taskactions.cpp, line 384 > > > > > > we have a name, it should be used. it hardly matters what the eventual > > Launcher is called. shorteni

Re: Review Request: TaskManager: TaskAction changes from IconTasks

2011-11-02 Thread Craig Drummond
> On Nov. 1, 2011, 2:05 p.m., Aaron J. Seigo wrote: > > libs/taskmanager/taskactions.cpp, line 384 > > > > > > we have a name, it should be used. it hardly matters what the eventual > > Launcher is called. shorteni

Re: Review Request: TaskManager: TaskAction changes from IconTasks

2011-11-01 Thread Craig Drummond
> On Nov. 1, 2011, 2:05 p.m., Aaron J. Seigo wrote: > > libs/taskmanager/taskactions.cpp, line 600 > > > > > > this is a misuse of QAction. you can add QActions to a QAction and that > > parent QAction becomes the

Re: Review Request: TaskManager: TaskAction changes from IconTasks

2011-11-01 Thread Aaron J. Seigo
> On Nov. 1, 2011, 2:05 p.m., Aaron J. Seigo wrote: > > a few issues with this patch, which can be divided into three types: > > > > * over simplification of the menu; i am all for reducing the items in this > > menu, including moving more to the "Advanced" submenu (which should > > probably b

Re: Review Request: TaskManager: TaskAction changes from IconTasks

2011-11-01 Thread Aaron J. Seigo
> On Nov. 1, 2011, 2:05 p.m., Aaron J. Seigo wrote: > > libs/taskmanager/taskactions.cpp, line 384 > > > > > > we have a name, it should be used. it hardly matters what the eventual > > Launcher is called. shorteni

Re: Review Request: TaskManager: TaskAction changes from IconTasks

2011-11-01 Thread Craig Drummond
> On Nov. 1, 2011, 2:05 p.m., Aaron J. Seigo wrote: > > a few issues with this patch, which can be divided into three types: > > > > * over simplification of the menu; i am all for reducing the items in this > > menu, including moving more to the "Advanced" submenu (which should > > probably b

Re: Review Request: TaskManager: TaskAction changes from IconTasks

2011-11-01 Thread Craig Drummond
> On Nov. 1, 2011, 2:05 p.m., Aaron J. Seigo wrote: > > libs/taskmanager/taskactions.cpp, line 135 > > > > > > why a property for this? why not simply: > > > > if (!act->toolTip().isEmpty()) { Using "if (!

Review Request: TaskManager: TaskAction changes from IconTasks

2011-11-01 Thread Craig Drummond
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103004/ --- Review request for Plasma. Description --- 1. Add NewInstance action