Re: Review Request: Plasmate:void ProjectManager::removeDirectory works correctly

2011-08-25 Thread Giorgos Tsiapaliwkas
Due to a misclick I replied only to sebas. The patches have been commited except from one. -- Tsiapaliwkas Giorgos (terietor) KDE Developer terietor.gr ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-de

Re: Review Request: Plasmate:void ProjectManager::removeDirectory works correctly

2011-08-23 Thread Sebastian Kügler
On Wednesday, June 08, 2011 23:51:03 Giorgos Tsiapaliwkas wrote: > http://git.reviewboard.kde.org/r/101550/ > the method removeDirectory wasn't removing the parent folder. > For example,if we named out plasmoid my_plasmoid it would have a directory > like this "$(kde4-config > --localprefix)/share

Re: Review Request: Plasmate:void ProjectManager::removeDirectory works correctly

2011-07-24 Thread Giorgos Tsiapaliwkas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101550/ --- (Updated July 24, 2011, 8:45 p.m.) Review request for Plasma. Changes --

Re: Review Request: Plasmate:void ProjectManager::removeDirectory works correctly

2011-07-22 Thread Aaron J. Seigo
> On July 19, 2011, 10:50 p.m., Aaron J. Seigo wrote: > > projectmanager/projectmanager.cpp, lines 107-109 > > > > > > so now it will _only_ delete local projects? > > > > or even worse: if you have a proje

Re: Review Request: Plasmate:void ProjectManager::removeDirectory works correctly

2011-07-20 Thread Giorgos Tsiapaliwkas
> On July 19, 2011, 10:50 p.m., Aaron J. Seigo wrote: > > projectmanager/projectmanager.cpp, lines 107-109 > > > > > > so now it will _only_ delete local projects? > > > > or even worse: if you have a proje

Re: Review Request: Plasmate:void ProjectManager::removeDirectory works correctly

2011-07-19 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101550/#review4878 --- projectmanager/projectmanager.cpp

Re: Review Request: Plasmate:void ProjectManager::removeDirectory works correctly

2011-07-19 Thread Giorgos Tsiapaliwkas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101550/ --- (Updated July 19, 2011, 11 a.m.) Review request for Plasma. Changes

Re: Review Request: Plasmate:void ProjectManager::removeDirectory works correctly

2011-07-13 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101550/#review4691 --- there is a problem with the cd(".."),otherwise it looks good. j

Re: Review Request: Plasmate:void ProjectManager::removeDirectory works correctly

2011-07-13 Thread Giorgos Tsiapaliwkas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101550/ --- (Updated July 13, 2011, 3 p.m.) Review request for Plasma. Changes -

Re: Review Request: Plasmate:void ProjectManager::removeDirectory works correctly

2011-06-20 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101550/#review4040 --- projectmanager/projectmanager.cpp

Review Request: Plasmate:void ProjectManager::removeDirectory works correctly

2011-06-08 Thread Giorgos Tsiapaliwkas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101550/ --- Review request for Plasma. Summary --- Hello, the method removeDirec