----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101550/#review4878 -----------------------------------------------------------
projectmanager/projectmanager.cpp <http://git.reviewboard.kde.org/r/101550/#comment4251> so now it will _only_ delete local projects? or even worse: if you have a project with the same name as a local project, it will delete the local one. what should be done is to see if the project _is_ a local project (e.g. the project starts with KStandardDirs::locateLocal("appdata", "/")) and if so do not do the cd("..") in deleteProject. - Aaron J. On July 19, 2011, 11 a.m., Giorgos Tsiapaliwkas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101550/ > ----------------------------------------------------------- > > (Updated July 19, 2011, 11 a.m.) > > > Review request for Plasma. > > > Summary > ------- > > Hello, > > the method removeDirectory wasn't removing the parent folder. > For example,if we named out plasmoid my_plasmoid it would have a directory > like this "$(kde4-config > --localprefix)/share/apps/plasmate/my_plasmoid/my_plasmoid" and the after > calling the removeDirectory(before the patch) method we would have a > directory like this: > ""$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/NOTES". > With the patch the entire folder my_plasmoid is being deleted. > > > Diffs > ----- > > mainwindow.cpp e08581f > projectmanager/projectmanager.h 53ef226 > projectmanager/projectmanager.cpp 122e48d > > Diff: http://git.reviewboard.kde.org/r/101550/diff > > > Testing > ------- > > compiles without issues and without regressions. > > > Thanks, > > Giorgos > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
