-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101550/
-----------------------------------------------------------

(Updated July 13, 2011, 3 p.m.)


Review request for Plasma.


Changes
-------

here is the KIO implementation.
Please let me know for any changes in my patch.

Moreover i changed a little bit the names.
I used project instead of folder.Is that ok?


Summary
-------

Hello,

the method removeDirectory wasn't removing the parent folder. 
For example,if we named out plasmoid my_plasmoid it would have a directory like 
this "$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/my_plasmoid" 
and the after calling the removeDirectory(before the patch) method we would 
have a directory like this:
""$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/NOTES".
With the patch the entire folder my_plasmoid is being deleted.


Diffs (updated)
-----

  projectmanager/projectmanager.h 53ef226 
  projectmanager/projectmanager.cpp 122e48d 

Diff: http://git.reviewboard.kde.org/r/101550/diff


Testing
-------

compiles without issues and without regressions.


Thanks,

Giorgos

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to