Re: Review Request: Plasmate: Add Tabbox support to the startpage

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105011/#review14525 --- Ship it! I still think that the template is quite bad and a be

Re: Review Request: Plasmate: Add Tabbox support to the startpage

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105011/ --- (Updated June 6, 2012, 1:27 p.m.) Review request for kwin, Plasma and Mart

Re: Review Request: Plasmate: Add Tabbox support to the startpage

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105011/#review14324 --- the template is still wrong, apart from that I would say it loo

Re: Review Request: Plasmate: Add Tabbox support to the startpage

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105011/ --- (Updated May 30, 2012, 3:43 p.m.) Review request for kwin, Plasma and Mart

Re: Review Request: Plasmate: Add Tabbox support to the startpage

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105011/ --- (Updated May 25, 2012, 2:27 p.m.) Review request for kwin, Plasma and Mart

Re: Review Request: Plasmate: Add Tabbox support to the startpage

> On May 24, 2012, 6:46 a.m., Martin Gräßlin wrote: > > > > Antonis Tsiapaliokas wrote: > There is still a big issue here. > > The template of the tabbox that i have put is located in the > kde-workspace/kwin/kcmkwin/kwintabbox/qml/main.qml. The main.qml cannot be > installed becu

Re: Review Request: Plasmate: Add Tabbox support to the startpage

> On May 24, 2012, 6:46 a.m., Martin Gräßlin wrote: > > > > Antonis Tsiapaliokas wrote: > There is still a big issue here. > > The template of the tabbox that i have put is located in the > kde-workspace/kwin/kcmkwin/kwintabbox/qml/main.qml. The main.qml cannot be > installed becu

Re: Review Request: Plasmate: Add Tabbox support to the startpage

> On May 24, 2012, 6:46 a.m., Martin Gräßlin wrote: > > > > Antonis Tsiapaliokas wrote: > There is still a big issue here. > > The template of the tabbox that i have put is located in the > kde-workspace/kwin/kcmkwin/kwintabbox/qml/main.qml. The main.qml cannot be > installed becu

Re: Review Request: Plasmate: Add Tabbox support to the startpage

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105011/ --- (Updated May 24, 2012, 1:17 p.m.) Review request for kwin, Plasma and Mart

Re: Review Request: Plasmate: Add Tabbox support to the startpage

> On May 24, 2012, 6:46 a.m., Martin Gräßlin wrote: > > There is still a big issue here. The template of the tabbox that i have put is located in the kde-workspace/kwin/kcmkwin/kwintabbox/qml/main.qml. The main.qml cannot be installed becuase it uses some Q_PROPERTY elements. Any ideas about

Re: Review Request: Plasmate: Add Tabbox support to the startpage

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105011/#review14107 --- startpage.cpp

Re: Review Request: Plasmate: Add Tabbox support to the startpage

On Wednesday, May 23, 2012 05:20:25 Antonis Tsiapaliokas wrote: > 2)Some lines doesn't have any differences > because i have remove some whitespaces and "tabs"... In the future, please put them in a separate patch, that makes reviewing a lot easier. > 1)The icons for the tabbox are wrong. I have

Re: Review Request: Plasmate: Add Tabbox support to the startpage

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105011/ --- (Updated May 23, 2012, 5:20 a.m.) Review request for kwin, Plasma and Mart