> On May 24, 2012, 6:46 a.m., Martin Gräßlin wrote: > >
There is still a big issue here. The template of the tabbox that i have put is located in the kde-workspace/kwin/kcmkwin/kwintabbox/qml/main.qml. The main.qml cannot be installed becuase it uses some Q_PROPERTY elements. Any ideas about how to fix that? Also i will update my diff, but for a quicker review please look at my comments :) > On May 24, 2012, 6:46 a.m., Martin Gräßlin wrote: > > startpage.cpp, line 146 > > <http://git.reviewboard.kde.org/r/105011/diff/1/?file=65127#file65127line146> > > > > I would use a kwin icon for TabBox and I think TabBox is a really, > > really bad name. > > > > I tend to call it "Window Switcher", the KCM is called "Task Switcher" I have change the "Tabbox" to "Window Switcher". As regards the icon, i am sorry for that but i have not change it because i have an issue with my kde environmnet and i cannot open a new KDE session. > On May 24, 2012, 6:46 a.m., Martin Gräßlin wrote: > > startpage.cpp, line 332 > > <http://git.reviewboard.kde.org/r/105011/diff/1/?file=65127#file65127line332> > > > > be aware of correct writing: KWin/TabBox would be the way it is called > > inside KWin. I have change it to "Kwin/WindowSwitcher"... > On May 24, 2012, 6:46 a.m., Martin Gräßlin wrote: > > templates/mainTabbox.qml, line 5 > > <http://git.reviewboard.kde.org/r/105011/diff/1/?file=65129#file65129line5> > > > > you should fill in the copyright :-) On startpage.cpp:466 we replacing the $AUTHOR and the $EMAIL with the real values which they have been provided by the user. - Antonis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105011/#review14107 ----------------------------------------------------------- On May 23, 2012, 5:20 a.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105011/ > ----------------------------------------------------------- > > (Updated May 23, 2012, 5:20 a.m.) > > > Review request for kwin, Plasma and Martin Gräßlin. > > > Description > ------- > > Hello, > > This is the first task of my GSoC. I have add the tabbox support to the > startpage of the plasmate. > > NOTES: > > 1)The service type of the tabbox is "Kwin/Tabbox,Plasma/Applet", because the > Plasma::PackageStructure requires the "Plasma/Applet" in order to be able to > be used. Also the plasmapkg and the plasmoidview require the "Plasma/Applet" > service type. > 2)Some lines doesn't have any differences because i have remove some > whitespaces and "tabs"... > > ISSUES: > > 1)The icons for the tabbox are wrong. I have some issues with my PCs and i > cannot open a new session of the KDE. > So i wasn't able to find the icon. Sorry for that. > 2)The template of the tabbox that i have put is located in the > kde-workspace/kwin/kcmkwin/kwintabbox/qml/main.qml. The main.qml cannot be > installed becuase it uses some Q_PROPERTY elements. Any ideas about how to > fix that? > 3)I think that the starting comments of the tabbox should become better. I > would prefer something like the "mainPlasmoid.qml".... > > > Diffs > ----- > > templates/CMakeLists.txt 6a82772 > templates/mainTabbox.qml PRE-CREATION > startpage.h 0df4c21 > startpage.cpp 9774b48 > editors/metadata/metadataeditor.cpp fce65fd > editors/editpage.cpp a331ae5 > > Diff: http://git.reviewboard.kde.org/r/105011/diff/ > > > Testing > ------- > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/105011/s/574/ > > > Thanks, > > Antonis Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
