> On May 24, 2012, 6:46 a.m., Martin Gräßlin wrote: > > > > Antonis Tsiapaliokas wrote: > There is still a big issue here. > > The template of the tabbox that i have put is located in the > kde-workspace/kwin/kcmkwin/kwintabbox/qml/main.qml. The main.qml cannot be > installed becuase it uses some Q_PROPERTY elements. Any ideas about how to > fix that? > > Also i will update my diff, but for a quicker review please look at my > comments :) > > Martin Gräßlin wrote: > I don't understand what you mean with the Q_PROPERTY elements and what > exactly you want to install. > > Antonis Tsiapaliokas wrote: > Since tabbox is written in qml and it uses plasma structure. It should be > able to be installed with plasmapkg (which it does) and it should be shown > with the plasmoidviewer. But if you run it with the plasmoidviewer, the > variables "sourcePath" and "name" cannot be found. Because they are > "Q_PROPERTIES". Please take a look at LayoutPreview::setLayout on > kde-workspace/kwin/kcmkwin/kwintabbox/layoutpreview.cpp
of course plasmoidviewer cannot work and will never work. As the name implies plasmoidviewer is for plasmoids and not for KWin :-) You need a dedicated preview capability for KWin switchers (and other KWin elements) - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105011/#review14107 ----------------------------------------------------------- On May 24, 2012, 1:17 p.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105011/ > ----------------------------------------------------------- > > (Updated May 24, 2012, 1:17 p.m.) > > > Review request for kwin, Plasma and Martin Gräßlin. > > > Description > ------- > > Hello, > > This is the first task of my GSoC. I have add the tabbox support to the > startpage of the plasmate. > > NOTES: > > 1)The service type of the tabbox is "Kwin/Tabbox,Plasma/Applet", because the > Plasma::PackageStructure requires the "Plasma/Applet" in order to be able to > be used. Also the plasmapkg and the plasmoidview require the "Plasma/Applet" > service type. > 2)Some lines doesn't have any differences because i have remove some > whitespaces and "tabs"... > > ISSUES: > > 1)The icons for the tabbox are wrong. I have some issues with my PCs and i > cannot open a new session of the KDE. > So i wasn't able to find the icon. Sorry for that. > 2)The template of the tabbox that i have put is located in the > kde-workspace/kwin/kcmkwin/kwintabbox/qml/main.qml. The main.qml cannot be > installed becuase it uses some Q_PROPERTY elements. Any ideas about how to > fix that? > 3)I think that the starting comments of the tabbox should become better. I > would prefer something like the "mainPlasmoid.qml".... > > > Diffs > ----- > > editors/editpage.cpp a331ae5 > editors/metadata/metadataeditor.cpp fce65fd > startpage.h 0df4c21 > startpage.cpp 9774b48 > templates/CMakeLists.txt 6a82772 > > Diff: http://git.reviewboard.kde.org/r/105011/diff/ > > > Testing > ------- > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/105011/s/574/ > > > Thanks, > > Antonis Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
