Re: Review Request: Fix bug 276082 and refactor timeline in plasmate

> On June 27, 2011, 11:51 a.m., Aaron J. Seigo wrote: > > looks good, minus the two small memory leaks; i'm not as convinced that the > > direction of the timeline is "correct" but let's keep it this way for now. > > after fixing the two memory leaks, please commit... cheers :) Yes, i am not c

Re: Review Request: Fix bug 276082 and refactor timeline in plasmate

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101728/#review4196 --- Ship it! looks good, minus the two small memory leaks; i'm not

Re: Review Request: Fix bug 276082 and refactor timeline in plasmate

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101728/ --- (Updated June 25, 2011, 10:01 p.m.) Review request for Plasma. Changes -

Re: Review Request: Fix bug 276082 and refactor timeline in plasmate

> On June 23, 2011, 6:29 p.m., Etienne Rebetez wrote: > > savesystem/timeline.cpp, line 197 > > > > > > Thats, basicaly the fix. The idea was to have the commits in the list > > in the same order as they appear in

Re: Review Request: Fix bug 276082 and refactor timeline in plasmate

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101728/#review4104 --- savesystem/timeline.cpp

Re: Review Request: Fix bug 276082 and refactor timeline in plasmate

> On June 23, 2011, 9:24 a.m., Aaron J. Seigo wrote: > > thanks for the patch. i believe it needs some work before it can go in, > > however. > > > > first off: where is the bug fix, precisely? the patch is large and the bug > > fix is evidently somewhere in there. > > > > after that, there a

Review Request: Fix bug 276082 and refactor timeline in plasmate

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101728/ --- Review request for Plasma. Summary --- Hi, When trying out plasmate