----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101728/ -----------------------------------------------------------
(Updated June 25, 2011, 10:01 p.m.) Review request for Plasma. Changes ------- During the process of coding and testing i realised the following: - Having the newest timelineitems on the left (horizontal) made sens, when not all timelineitems are visible. - When vertical, it seams natural to have the newes timeline items on the top. So this means the inital behavior was/is better and there is no bug:) But since i allready lost data with the assumption that time goes from left to right, i figured out that it has to be made clear what timelineitem you are about to reset. So i added the following: - The timelineitems show now the date/time as their text - The first item (oldest) is marked as such - A "create new savepoint" icon is placed where the new timelineitems are inserted - And the context menu of the timlineitems shows more information (tooltip text) The git log parsing is almost identical to the current one. When closing a project and opening another, the timeline was not updated (showed the old project). I fixed that too. I also tried to set the whitspaces and brakets right. Summary ------- Hi, When trying out plasmate the last day, i was hit with the bug 276082. Since i didn't want that it happens to someone else, i made a fix for it. I the process i found that the loadTimeLine function was far to big. So i did also some refactoring. (this diff is kinda huge but i made the changes in a branch which i can merge to master) The timeliene and savepoint creation should now behave as expected. Let me know what you think. Etienne PS: How is the commit policy in plasmate? Could i just push directly to master in the future? Diffs (updated) ----- mainwindow.cpp 8326a29 savesystem/tablewidget.cpp 39e8761 savesystem/timeline.h 719fb73 savesystem/timeline.cpp d258a1a savesystem/timelineitem.h 1e9699f savesystem/timelineitem.cpp d9b0a67 Diff: http://git.reviewboard.kde.org/r/101728/diff Testing ------- Thanks, Etienne
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
