> On June 23, 2011, 6:29 p.m., Etienne Rebetez wrote: > > savesystem/timeline.cpp, line 197 > > <http://git.reviewboard.kde.org/r/101728/diff/1/?file=24893#file24893line197> > > > > Thats, basicaly the fix. The idea was to have the commits in the list > > in the same order as they appear in the timeline. > > But, with your suggestion i'll probaly try to make the TimeLineItem in > > the same loop.
aha, ok, that makes lots of sense.. it is probably even worth providing a comment as to why it's "prepend" instead of "append"... i look forward to the updated version of this patch.. thanks again for working on fixing this! - Aaron J. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101728/#review4104 ----------------------------------------------------------- On June 22, 2011, 7:37 p.m., Etienne Rebetez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101728/ > ----------------------------------------------------------- > > (Updated June 22, 2011, 7:37 p.m.) > > > Review request for Plasma. > > > Summary > ------- > > Hi, > > When trying out plasmate the last day, i was hit with the bug 276082. Since i > didn't want that it happens to someone else, i made a fix for it. > I the process i found that the loadTimeLine function was far to big. So i did > also some refactoring. (this diff is kinda huge but i made the changes in a > branch which i can merge to master) > The timeliene and savepoint creation should now behave as expected. > > Let me know what you think. > Etienne > > PS: How is the commit policy in plasmate? Could i just push directly to > master in the future? > > > Diffs > ----- > > mainwindow.cpp 8326a29 > savesystem/timeline.h 719fb73 > savesystem/timeline.cpp d258a1a > savesystem/timelineitem.h 1e9699f > savesystem/timelineitem.cpp d9b0a67 > > Diff: http://git.reviewboard.kde.org/r/101728/diff > > > Testing > ------- > > > Thanks, > > Etienne > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
