Re: Review Request: Allow AbstractRunner to parse QMenus for actions

2009-07-25 Thread Ryan Bitanga
> On 2009-07-25 05:24:44, Aaron Seigo wrote: > > does this really belong in AbstractRunner? obviously, it's runners that are > > currently using it, but this method doesn't actually have anything to do > > with the functionality AbstractRunner provides. maybe it should be added to > > plasma.h

Re: Review Request: Allow AbstractRunner to parse QMenus for actions

2009-07-25 Thread Aaron Seigo
> On 2009-07-25 05:24:44, Aaron Seigo wrote: > > does this really belong in AbstractRunner? obviously, it's runners that are > > currently using it, but this method doesn't actually have anything to do > > with the functionality AbstractRunner provides. maybe it should be added to > > plasma.h

Re: Review Request: Allow AbstractRunner to parse QMenus for actions

2009-07-24 Thread Ryan Bitanga
> On 2009-07-25 05:24:44, Aaron Seigo wrote: > > does this really belong in AbstractRunner? obviously, it's runners that are > > currently using it, but this method doesn't actually have anything to do > > with the functionality AbstractRunner provides. maybe it should be added to > > plasma.h

Re: Review Request: Allow AbstractRunner to parse QMenus for actions

2009-07-24 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1115/#review1760 --- does this really belong in AbstractRunner? obviously, it's runners tha

Re: Review Request: Allow AbstractRunner to parse QMenus for actions

2009-07-24 Thread Chani
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1115/#review1758 --- Ship it! I don't really know anything about runners, but the code loo

Re: Review Request: Allow AbstractRunner to parse QMenus for actions

2009-07-24 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1115/ --- (Updated 2009-07-25 01:24:26.349811) Review request for Plasma. Changes --

Re: Review Request: Allow AbstractRunner to parse QMenus for actions

2009-07-24 Thread Chani
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1115/#review1754 --- trunk/KDE/kdelibs/plasma/abstractrunner.cpp

Review Request: Allow AbstractRunner to parse QMenus for actions

2009-07-24 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1115/ --- Review request for Plasma. Summary --- This adds a convenience method to Ab