----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1115/#review1754 -----------------------------------------------------------
trunk/KDE/kdelibs/plasma/abstractrunner.cpp <http://reviewboard.kde.org/r/1115/#comment1146> I don't see any reason to create a new variable here. aText, text... just use one. trunk/KDE/kdelibs/plasma/abstractrunner.cpp <http://reviewboard.kde.org/r/1115/#comment1145> I'd prefer it if that replace string was done only once, separate from the prefix text - Chani On 2009-07-24 13:21:55, Ryan Bitanga wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1115/ > ----------------------------------------------------------- > > (Updated 2009-07-24 13:21:55) > > > Review request for Plasma. > > > Summary > ------- > > This adds a convenience method to AbstractRunner to extract a list of actions > from a QMenu. Hierarchy is preserved by prefixing submenu text to the actions > in the submenus. > > Current uses are extracting actions from KFileItemActions and libtaskmanager. > The code is currently used by the window management runner in playground, the > multiple action nepomuk search runner patch in reviewboard, and fsrunner in > kde-apps.org. This method will help avoid code duplication in these runners > as well as future runners that can extract info from menus. > > > Diffs > ----- > > trunk/KDE/kdelibs/plasma/abstractrunner.h 999602 > trunk/KDE/kdelibs/plasma/abstractrunner.cpp 999602 > > Diff: http://reviewboard.kde.org/r/1115/diff > > > Testing > ------- > > > Thanks, > > Ryan > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
