> On 2009-07-25 05:24:44, Aaron Seigo wrote: > > does this really belong in AbstractRunner? obviously, it's runners that are > > currently using it, but this method doesn't actually have anything to do > > with the functionality AbstractRunner provides. maybe it should be added to > > plasma.h instead? > > Ryan Bitanga wrote: > I couldn't think of any other use case so I opted to keep it as a > protected function of AbstractRunner. I'm not sure having a public function > for retrieving a list of actions would be useful to any other application but > if anyone can think of another use for it, we could move it to plasma.h
it's not about having other uses of the method, it's simply that this method has _nothing_ to do with AbstractRunner. it's just a coincidence that only runners are using this right now. since we can change API after it's introduced, this concerns me. :) if it does stay in AbstractRunner and we later move it, then the method in AbstractRunner would become a wrapper around the one in the Plasma namespace. i don't see any reason not to just it in Plasma:: in the first place, and then we don't need to worry if others will want to use it in the future or not: it's already somewhere everyone can get at it. - Aaron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1115/#review1760 ----------------------------------------------------------- On 2009-07-25 01:24:26, Ryan Bitanga wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1115/ > ----------------------------------------------------------- > > (Updated 2009-07-25 01:24:26) > > > Review request for Plasma. > > > Summary > ------- > > This adds a convenience method to AbstractRunner to extract a list of actions > from a QMenu. Hierarchy is preserved by prefixing submenu text to the actions > in the submenus. > > Current uses are extracting actions from KFileItemActions and libtaskmanager. > The code is currently used by the window management runner in playground, the > multiple action nepomuk search runner patch in reviewboard, and fsrunner in > kde-apps.org. This method will help avoid code duplication in these runners > as well as future runners that can extract info from menus. > > > Diffs > ----- > > trunk/KDE/kdelibs/plasma/abstractrunner.h 1001909 > trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1001909 > > Diff: http://reviewboard.kde.org/r/1115/diff > > > Testing > ------- > > > Thanks, > > Ryan > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
