Re: Review Request: Add keyboard navigation to plasma applet Folder View

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/368/#review886 --- Ship it! Aside from a couple of minor nitpicks below I think the patch

Re: Review Request: Add keyboard navigation to plasma applet Folder View

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/368/ --- (Updated 2009-04-08 21:33:17.329268) Review request for Plasma. Changes ---

Re: Review Request: Add keyboard navigation to plasma applet Folder View

> On 2009-04-02 13:56:47, Fredrik Höglund wrote: > > I think in general the code looks good, but there are still numerous coding > > style issues, especially with the way the code is indented. > > Shantanu Tushar Jha wrote: > Oh, I apologise for that, but I'm unable to figure out where I've

Re: Review Request: Add keyboard navigation to plasma applet Folder View

> On 2009-04-02 13:56:47, Fredrik Höglund wrote: > > I think in general the code looks good, but there are still numerous coding > > style issues, especially with the way the code is indented. > > Shantanu Tushar Jha wrote: > Oh, I apologise for that, but I'm unable to figure out where I've

Re: Review Request: Add keyboard navigation to plasma applet Folder View

> On 2009-04-02 13:56:47, Fredrik Höglund wrote: > > I think in general the code looks good, but there are still numerous coding > > style issues, especially with the way the code is indented. Oh, I apologise for that, but I'm unable to figure out where I've messed up with the indentation. Ple

Re: Review Request: Add keyboard navigation to plasma applet Folder View

> On 2009-03-20 14:07:32, Fredrik Höglund wrote: > > /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp, line 1208 > > > > > > A problem with the way this function is implemented is that it assumes > > that the

Re: Review Request: Add keyboard navigation to plasma applet Folder View

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/368/#review796 --- I think in general the code looks good, but there are still numerous cod

Re: Review Request: Add keyboard navigation to plasma applet Folder View

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/368/ --- (Updated 2009-04-02 13:21:02.238361) Review request for Plasma. Changes ---

Re: Review Request: Add keyboard navigation to plasma applet Folder View

> On 2009-03-20 14:07:32, Fredrik Höglund wrote: > > /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp, line 1208 > > > > > > A problem with the way this function is implemented is that it assumes > > that the

Re: Review Request: Add keyboard navigation to plasma applet Folder View

> On 2009-03-20 14:07:32, Fredrik Höglund wrote: > > /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp, line 1208 > > > > > > A problem with the way this function is implemented is that it assumes > > that the

Re: Review Request: Add keyboard navigation to plasma applet Folder View

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/368/ --- (Updated 2009-04-02 08:55:49.469863) Review request for Plasma. Changes ---

Re: Review Request: Add keyboard navigation to plasma applet Folder View

> On 2009-03-20 14:07:32, Fredrik Höglund wrote: > > /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp, line 1208 > > > > > > A problem with the way this function is implemented is that it assumes > > that the

Re: Review Request: Add keyboard navigation to plasma applet Folder View

> On 2009-03-20 14:07:32, Fredrik Höglund wrote: > > /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp, line 1208 > > > > > > A problem with the way this function is implemented is that it assumes > > that the

Re: Review Request: Add keyboard navigation to plasma applet Folder View

> On 2009-03-20 14:07:32, Fredrik Höglund wrote: > > /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp, line 1208 > > > > > > A problem with the way this function is implemented is that it assumes > > that the

Re: Review Request: Add keyboard navigation to plasma applet Folder View

> On 2009-03-20 14:07:32, Fredrik Höglund wrote: > > /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp, line 1255 > > > > > > The implementation of this function suffers from the same problem as > > the one ab

Re: Review Request: Add keyboard navigation to plasma applet Folder View

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/368/ --- (Updated 2009-03-20 22:14:51.976726) Review request for Plasma. Changes ---

Re: Review Request: Add keyboard navigation to plasma applet Folder View

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/368/#review541 --- I have some comments in addition to the coding style issues mentioned by

Re: Review Request: Add keyboard navigation to plasma applet Folder View

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/368/#review540 --- logic looks alright, just a couple of code style issues to fix and then

Re: Review Request: Add keyboard navigation to plasma applet Folder View

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/368/ --- (Updated 2009-03-20 10:21:32.420468) Review request for Plasma. Changes ---

Re: Review Request: Add keyboard navigation to plasma applet Folder View

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/368/#review537 --- this is a very important feature to add, so thanks for working on it. th

Review Request: Add keyboard navigation to plasma applet Folder View

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/368/ --- Review request for Plasma. Summary --- This partly addresses the above bug,