----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/368/#review540 -----------------------------------------------------------
logic looks alright, just a couple of code style issues to fix and then you can commit this to svn. note that we use the kdelibs coding style in plasma. the style is documented here: http://techbase.kde.org/Policies/Kdelibs_Coding_Style /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp <http://reviewboard.kde.org/r/368/#comment328> please check the spacing in all your if statements: if (foo) {, not if( foo ) {. /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp <http://reviewboard.kde.org/r/368/#comment329> code style: if (foo) { } else if (foo) { } else { } - Aaron On 2009-03-20 10:21:32, Shantanu Tushar Jha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/368/ > ----------------------------------------------------------- > > (Updated 2009-03-20 10:21:32) > > > Review request for Plasma. > > > Summary > ------- > > This partly addresses the above bug, adding keyboard navigation and launch > using Enter key. > Please report if the code is too complex, I've tried my best to keep it to > the point. > > > This addresses bug 187241. > https://bugs.kde.org/show_bug.cgi?id=187241 > > > Diffs > ----- > > /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 941694 > /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 941694 > > Diff: http://reviewboard.kde.org/r/368/diff > > > Testing > ------- > > Tested on latest SVN build. Navigation and launch work fine. The problem is > with movement of the scrollbar with the keyboard focus, the scrollbar refuses > to go to minimum value when m_scrollBar->setValue( m_scrollBar->minimum() ); > is used. What am I doing wrong? > > > Thanks, > > Shantanu > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
