-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/368/
-----------------------------------------------------------
(Updated 2009-04-08 21:33:17.329268)
Review request for Plasma.
Changes
-------
1.Indentation changed from 2 spaces to 4 spaces.
2.ScrollTo function moved to AbstractItemView class.
3.setFocusPolicy(Qt::StrongFocus) redundancy removed. Now it exists only in the
constructor.
4.Attempt to resolve the issue with m_columns being 0
5.Modified code to work with all existing flow values - LeftToRight,
TopToBottom, RightToLeft, TopToBottomRightToLeft.
Please review and comment if something is wrong :)
Summary
-------
This partly addresses the above bug, adding keyboard navigation and launch
using Enter key.
Please report if the code is too complex, I've tried my best to keep it to the
point.
This addresses bug 187241.
https://bugs.kde.org/show_bug.cgi?id=187241
Diffs (updated)
-----
/trunk/KDE/kdebase/apps/plasma/applets/folderview/abstractitemview.h 951365
/trunk/KDE/kdebase/apps/plasma/applets/folderview/abstractitemview.cpp 951365
/trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 951365
/trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 951365
Diff: http://reviewboard.kde.org/r/368/diff
Testing
-------
Tested on latest SVN build. Navigation and launch work fine. The problem is
with movement of the scrollbar with the keyboard focus, the scrollbar refuses
to go to minimum value when m_scrollBar->setValue( m_scrollBar->minimum() ); is
used. What am I doing wrong?
Thanks,
Shantanu
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
