Re: Review Request 125802: Split generic parts from X11Locker into AbstractLocker

2015-10-26 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125802/ --- (Updated Oct. 26, 2015, 1:36 p.m.) Status -- This change has been ma

Re: Review Request 125802: Split generic parts from X11Locker into AbstractLocker

2015-10-26 Thread Bhushan Shah
> On Oct. 26, 2015, 5:32 p.m., David Edmundson wrote: > > ksmserver/screenlocker/abstractlocker.h, line 68 > > > > > > I don't like this set. > > > > It means if you use globalAccel() from X11Locker's con

Re: Review Request 125802: Split generic parts from X11Locker into AbstractLocker

2015-10-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125802/#review87422 --- Ship it! ship it! I include a grumble about something that e

Re: Review Request 125802: Split generic parts from X11Locker into AbstractLocker

2015-10-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125802/#review87404 --- +1, looks good to me. Let's give it some time for other devs t

Re: Review Request 125802: Split generic parts from X11Locker into AbstractLocker

2015-10-26 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125802/ --- (Updated Oct. 26, 2015, 1:41 p.m.) Review request for Plasma and Martin G

Re: Review Request 125802: Split generic parts from X11Locker into AbstractLocker

2015-10-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125802/#review87402 --- ksmserver/screenlocker/abstractlocker.h (line 66)

Re: Review Request 125802: Split generic parts from X11Locker into AbstractLocker

2015-10-26 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125802/ --- (Updated Oct. 26, 2015, 1:02 p.m.) Review request for Plasma and Martin G

Re: Review Request 125802: Split generic parts from X11Locker into AbstractLocker

2015-10-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125802/#review87400 --- Difficult to read on reviewboard. Overall it looks good to me,