Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

2015-03-08 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122239/ --- (Updated March 8, 2015, 12:33 p.m.) Status -- This change has been m

Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

2015-03-02 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122239/#review76937 --- Ship it! Ship It! - Sebastian Kügler On Jan. 24, 2015, 11:

Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

2015-02-27 Thread Sebastian Kügler
> On Jan. 26, 2015, 9:08 a.m., Marco Martin wrote: > > where do you want to use it? > > Iirc Bhushan is working o a global way to make series of kcms accessible > > from plasmoids > > David Edmundson wrote: > Generic is always better. > KDeclarative is used from places outside Plasma. A

Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

2015-02-26 Thread Kai Uwe Broulik
> On Jan. 26, 2015, 9:08 vorm., Marco Martin wrote: > > where do you want to use it? > > Iirc Bhushan is working o a global way to make series of kcms accessible > > from plasmoids > > David Edmundson wrote: > Generic is always better. > KDeclarative is used from places outside Plasma.

Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

2015-02-09 Thread Sebastian Kügler
> On Jan. 26, 2015, 9:08 a.m., Marco Martin wrote: > > where do you want to use it? > > Iirc Bhushan is working o a global way to make series of kcms accessible > > from plasmoids > > David Edmundson wrote: > Generic is always better. > KDeclarative is used from places outside Plasma. A

Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

2015-02-09 Thread Marco Martin
> On Jan. 26, 2015, 9:08 a.m., Marco Martin wrote: > > where do you want to use it? > > Iirc Bhushan is working o a global way to make series of kcms accessible > > from plasmoids > > David Edmundson wrote: > Generic is always better. > KDeclarative is used from places outside Plasma. A

Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

2015-02-07 Thread Kai Uwe Broulik
> On Jan. 26, 2015, 9:08 vorm., Marco Martin wrote: > > where do you want to use it? > > Iirc Bhushan is working o a global way to make series of kcms accessible > > from plasmoids > > David Edmundson wrote: > Generic is always better. > KDeclarative is used from places outside Plasma.

Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

2015-01-28 Thread Sebastian Kügler
> On Jan. 26, 2015, 9:08 a.m., Marco Martin wrote: > > where do you want to use it? > > Iirc Bhushan is working o a global way to make series of kcms accessible > > from plasmoids > > David Edmundson wrote: > Generic is always better. > KDeclarative is used from places outside Plasma. A

Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

2015-01-27 Thread Bhushan Shah
> On Jan. 26, 2015, 2:38 p.m., Marco Martin wrote: > > where do you want to use it? > > Iirc Bhushan is working o a global way to make series of kcms accessible > > from plasmoids > > David Edmundson wrote: > Generic is always better. > KDeclarative is used from places outside Plasma. A

Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

2015-01-26 Thread Marco Martin
> On Jan. 26, 2015, 9:08 a.m., Marco Martin wrote: > > where do you want to use it? > > Iirc Bhushan is working o a global way to make series of kcms accessible > > from plasmoids > > David Edmundson wrote: > Generic is always better. > KDeclarative is used from places outside Plasma. A

Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

2015-01-26 Thread Bhushan Shah
> On Jan. 26, 2015, 2:38 p.m., Marco Martin wrote: > > where do you want to use it? > > Iirc Bhushan is working o a global way to make series of kcms accessible > > from plasmoids > > David Edmundson wrote: > Generic is always better. > KDeclarative is used from places outside Plasma. A

Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

2015-01-26 Thread David Edmundson
> On Jan. 26, 2015, 9:08 a.m., Marco Martin wrote: > > where do you want to use it? > > Iirc Bhushan is working o a global way to make series of kcms accessible > > from plasmoids Generic is always better. KDeclarative is used from places outside Plasma. Applications in future will need to ope

Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

2015-01-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122239/#review74750 --- where do you want to use it? Iirc Bhushan is working o a globa

Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

2015-01-25 Thread David Edmundson
On Jan. 25, 2015, 4:09 p.m., Kai Uwe Broulik wrote: > > Shouldn't we be using KService here? Crazy alternative to consider Expose http://api.kde.org/frameworks-api/frameworks5-apidocs/kcmutils/html/classKSettings_1_1Dialog.html directly to QML, making sure AddModule in invokable. - David

Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

2015-01-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122239/#review74709 --- +1 to the idea src/qmlcontrols/kquickcontrolsaddons/kcmshell

Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

2015-01-24 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122239/#review74685 --- Ship it! Ship It! - Lukáš Tinkl On Led. 25, 2015, 12:54 do

Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

2015-01-24 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122239/ --- (Updated Jan. 24, 2015, 11:54 nachm.) Review request for Plasma. Change

Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

2015-01-24 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122239/#review74683 --- src/qmlcontrols/kquickcontrolsaddons/kcmshell.h