----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122239/#review74709 -----------------------------------------------------------
+1 to the idea src/qmlcontrols/kquickcontrolsaddons/kcmshell.cpp <https://git.reviewboard.kde.org/r/122239/#comment51785> given we can open multiple modules it would be good to expose setting --caption and --icon - to kcmshell otherwise it just takes the name of first one plus "KDE Control Module" which is a bit messy. Shouldn't we be using KService here? - David Edmundson On Jan. 24, 2015, 11:54 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122239/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2015, 11:54 p.m.) > > > Review request for Plasma. > > > Repository: kdeclarative > > > Description > ------- > > Since there are already like 10 copies of the ProcessRunner for all kinds of > plasmoids wanting to open a KCM, this adds a KCMShell.open("foo") and > KCMShell.open(["foo", "bar", "baz"]) singleton. > > > Diffs > ----- > > src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 65e28ff > src/qmlcontrols/kquickcontrolsaddons/kcmshell.h PRE-CREATION > src/qmlcontrols/kquickcontrolsaddons/kcmshell.cpp PRE-CREATION > src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp 289f1ed > > Diff: https://git.reviewboard.kde.org/r/122239/diff/ > > > Testing > ------- > > Works. Dunno if the name causes clashes or this is the right place to put it. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
