Re: Review Request: make the DeviceNotifier Plasmoid scale with high-res screens

On Friday, November 23, 2012 18:15:43 Michael Zanetti wrote: > If I'm not completely blind the Plasma.Label does not support eliding, thats > why I clipped instead. PlasmaComponents.Label supports eliding as it inherits from the QtQuick Text item. -- sebas http://www.kde.org | http://vizZzion.o

Re: Review Request: make the DeviceNotifier Plasmoid scale with high-res screens

> On Nov. 26, 2012, 9:35 a.m., Marco Martin wrote: > > This is really an issue that needs addressing, thanks for taking time for > > it. > > > > i'm very in favor of removing all those hardcoded sizes from the code. > > > > however i see two problems with that approach > > > > 1) icons are cl

Re: Review Request: make the DeviceNotifier Plasmoid scale with high-res screens

> On Nov. 26, 2012, 9:35 a.m., Marco Martin wrote: > > This is really an issue that needs addressing, thanks for taking time for > > it. > > > > i'm very in favor of removing all those hardcoded sizes from the code. > > > > however i see two problems with that approach > > > > 1) icons are cl

Re: Review Request: make the DeviceNotifier Plasmoid scale with high-res screens

> On Nov. 26, 2012, 9:35 a.m., Marco Martin wrote: > > This is really an issue that needs addressing, thanks for taking time for > > it. > > > > i'm very in favor of removing all those hardcoded sizes from the code. > > > > however i see two problems with that approach > > > > 1) icons are cl

Re: Review Request: make the DeviceNotifier Plasmoid scale with high-res screens

> On Nov. 26, 2012, 9:35 a.m., Marco Martin wrote: > > This is really an issue that needs addressing, thanks for taking time for > > it. > > > > i'm very in favor of removing all those hardcoded sizes from the code. > > > > however i see two problems with that approach > > > > 1) icons are cl

Re: Review Request: make the DeviceNotifier Plasmoid scale with high-res screens

> On Nov. 26, 2012, 9:35 a.m., Marco Martin wrote: > > This is really an issue that needs addressing, thanks for taking time for > > it. > > > > i'm very in favor of removing all those hardcoded sizes from the code. > > > > however i see two problems with that approach > > > > 1) icons are cl

Re: Review Request: make the DeviceNotifier Plasmoid scale with high-res screens

> On Nov. 26, 2012, 9:35 a.m., Marco Martin wrote: > > This is really an issue that needs addressing, thanks for taking time for > > it. > > > > i'm very in favor of removing all those hardcoded sizes from the code. > > > > however i see two problems with that approach > > > > 1) icons are cl

Re: Review Request: make the DeviceNotifier Plasmoid scale with high-res screens

> On Nov. 26, 2012, 9:35 a.m., Marco Martin wrote: > > This is really an issue that needs addressing, thanks for taking time for > > it. > > > > i'm very in favor of removing all those hardcoded sizes from the code. > > > > however i see two problems with that approach > > > > 1) icons are cl

Re: Review Request: make the DeviceNotifier Plasmoid scale with high-res screens

> On Nov. 26, 2012, 9:35 a.m., Marco Martin wrote: > > This is really an issue that needs addressing, thanks for taking time for > > it. > > > > i'm very in favor of removing all those hardcoded sizes from the code. > > > > however i see two problems with that approach > > > > 1) icons are cl

Re: Review Request: make the DeviceNotifier Plasmoid scale with high-res screens

> On Nov. 26, 2012, 9:35 a.m., Marco Martin wrote: > > This is really an issue that needs addressing, thanks for taking time for > > it. > > > > i'm very in favor of removing all those hardcoded sizes from the code. > > > > however i see two problems with that approach > > > > 1) icons are cl

Re: Review Request: make the DeviceNotifier Plasmoid scale with high-res screens

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107428/#review22548 --- This is really an issue that needs addressing, thanks for takin

Re: Review Request: make the DeviceNotifier Plasmoid scale with high-res screens

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107428/#review22455 --- Thanks for addressing this issue, it is a pity that qml makes i

Re: Review Request: make the DeviceNotifier Plasmoid scale with high-res screens

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107428/ --- (Updated Nov. 23, 2012, 10:11 p.m.) Review request for Plasma and Kai Uwe

Re: Review Request: make the DeviceNotifier Plasmoid scale with high-res screens

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107428/ --- (Updated Nov. 23, 2012, 7:32 p.m.) Review request for Plasma and Kai Uwe B

Re: Review Request: make the DeviceNotifier Plasmoid scale with high-res screens

> On Nov. 23, 2012, 1:03 p.m., Kai Uwe Broulik wrote: > > plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml, > > line 129 > > > > > > Do two lines fit in? Maybe use > > elide: Text.ElideR

Re: Review Request: make the DeviceNotifier Plasmoid scale with high-res screens

> On Nov. 23, 2012, 1:03 p.m., Kai Uwe Broulik wrote: > > plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml, > > line 129 > > > > > > Do two lines fit in? Maybe use > > elide: Text.ElideR

Re: Review Request: make the DeviceNotifier Plasmoid scale with high-res screens

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107428/ --- (Updated Nov. 23, 2012, 6:15 p.m.) Review request for Plasma and Kai Uwe B