> On Nov. 23, 2012, 1:03 p.m., Kai Uwe Broulik wrote: > > plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml, > > line 129 > > <http://git.reviewboard.kde.org/r/107428/diff/1/?file=95873#file95873line129> > > > > Do two lines fit in? Maybe use > > elide: Text.ElideRight > > MaximumLineCount: 2 > > Michael Zanetti wrote: > If I'm not completely blind the Plasma.Label does not support eliding, > thats why I clipped instead. > > No, how it is currently, 2 lines would trash the layout as the icons size > is tied to the text height. I couldn't find anything reasonable to get a > dynamic size but still having it looking the same it did before.
ok... no clue in what docs I ended up yesterday... Anyways, I'll try to restore the wordwrap somehow before eliding... - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107428/#review22425 ----------------------------------------------------------- On Nov. 23, 2012, 6:15 p.m., Michael Zanetti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107428/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2012, 6:15 p.m.) > > > Review request for Plasma and Kai Uwe Broulik. > > > Description > ------- > > This adjustst the DeviceNotifier Plasmoid to scale nicely with high > resolution screens. > > The patch changes also one label from wordWrapping to clipping behavior > because otherwise it messes up the layout. > > > Diffs > ----- > > plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml > 1fab0ef > > plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml > f8728d0 > > Diff: http://git.reviewboard.kde.org/r/107428/diff/ > > > Testing > ------- > > Tested on High res screen at full DPI and at regular DPI values > > > Thanks, > > Michael Zanetti > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
