Re: Review Request: Plasmate: Add tabbox previewer

2012-06-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105139/#review14632 --- Ship it! You might consider using i18nc in future to make tran

Re: Review Request: Plasmate: Add tabbox previewer

2012-06-11 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105139/ --- (Updated June 11, 2012, 4:15 p.m.) Review request for kwin, Plasma and Mar

Re: Review Request: Plasmate: Add tabbox previewer

2012-06-10 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105139/ --- (Updated June 10, 2012, 9:25 a.m.) Review request for kwin, Plasma and Mar

Re: Review Request: Plasmate: Add tabbox previewer

2012-06-09 Thread Antonis Tsiapaliokas
> On June 9, 2012, 7:15 a.m., Martin Gräßlin wrote: > > previewer/tabbox/tabboxdelegate.qml, lines 2-3 > > > > > > although if it's copied from KWin, the file is in Plasmate not part of > > KWin ;-) I have remote th

Re: Review Request: Plasmate: Add tabbox previewer

2012-06-09 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105139/ --- (Updated June 9, 2012, 10:37 a.m.) Review request for kwin, Plasma and Mar

Re: Review Request: Plasmate: Add tabbox previewer

2012-06-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105139/#review14528 --- The standalone previewer is missing a Messages.sh, isn't it?

Re: Review Request: Plasmate: Add tabbox previewer

2012-06-06 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105139/ --- (Updated June 6, 2012, 1:28 p.m.) Review request for kwin, Plasma and Mart

Re: Review Request: Plasmate: Add tabbox previewer

2012-06-05 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105139/ --- (Updated June 5, 2012, 1:42 p.m.) Review request for kwin, Plasma and Mart

Re: Review Request: Plasmate: Add tabbox previewer

2012-06-03 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105139/ --- (Updated June 3, 2012, 4:21 p.m.) Review request for kwin, Plasma and Mart

Re: Review Request: Plasmate: Add tabbox previewer

2012-06-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105139/#review14395 --- I have not yet tried it. From the code it looks quite ok, only

Re: Review Request: Plasmate: Add tabbox previewer

2012-06-03 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105139/ --- (Updated June 3, 2012, 10:01 a.m.) Review request for kwin, Plasma and Mar