> On June 9, 2012, 7:15 a.m., Martin Gräßlin wrote: > > previewer/tabbox/tabboxdelegate.qml, lines 2-3 > > <http://git.reviewboard.kde.org/r/105139/diff/5/?file=66461#file66461line2> > > > > although if it's copied from KWin, the file is in Plasmate not part of > > KWin ;-)
I have remote the line #2. > On June 9, 2012, 7:15 a.m., Martin Gräßlin wrote: > > previewer/tabbox/windowswitcher.cpp, lines 34-36 > > <http://git.reviewboard.kde.org/r/105139/diff/5/?file=66471#file66471line34> > > > > why are here commented includes? They are commented because they are commented to the kwin/kcmkwin/kwintabbox/layoutpreview.cpp... Anyway i have remove them... > On June 9, 2012, 7:15 a.m., Martin Gräßlin wrote: > > previewer/tabbox/windowswitcher.cpp, line 42 > > <http://git.reviewboard.kde.org/r/105139/diff/5/?file=66471#file66471line42> > > > > ? I have remove the comments. > On June 9, 2012, 7:15 a.m., Martin Gräßlin wrote: > > previewer/tabbox/standalone/windowswitcherpreviewer.cpp, line 51 > > <http://git.reviewboard.kde.org/r/105139/diff/5/?file=66460#file66460line51> > > > > ? removed - Antonis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105139/#review14528 ----------------------------------------------------------- On June 9, 2012, 10:37 a.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105139/ > ----------------------------------------------------------- > > (Updated June 9, 2012, 10:37 a.m.) > > > Review request for kwin, Plasma and Martin Gräßlin. > > > Description > ------- > > Hello, > > This is the second task of my GSoC.Everything seems to work execpt from: > > 1)The icon of the refresh (in the tabbox previewer) is not visible. > 2)I couldn't try if the refresh works... > > > This addresses bug master. > http://bugs.kde.org/show_bug.cgi?id=master > > > Diffs > ----- > > CMakeLists.txt 12f8a3a > editors/metadata/metadataeditor.cpp fce65fd > mainwindow.cpp 6f72624 > previewer/tabbox/standalone/main.cpp PRE-CREATION > previewer/tabbox/standalone/windowswitcherpreviewer.h PRE-CREATION > previewer/tabbox/standalone/windowswitcherpreviewer.cpp PRE-CREATION > previewer/tabbox/tabboxdelegate.qml PRE-CREATION > previewer/tabbox/tabboxpreviewer.h PRE-CREATION > previewer/tabbox/tabboxpreviewer.cpp PRE-CREATION > previewer/tabbox/thumbnailitem.h PRE-CREATION > previewer/tabbox/thumbnailitem.cpp PRE-CREATION > previewer/tabbox/windowswitcher.h PRE-CREATION > previewer/tabbox/windowswitcher.cpp PRE-CREATION > startpage.cpp 9774b48 > > Diff: http://git.reviewboard.kde.org/r/105139/diff/ > > > Testing > ------- > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/105139/s/590/ > > > Thanks, > > Antonis Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
