----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105139/#review14528 -----------------------------------------------------------
The standalone previewer is missing a Messages.sh, isn't it? CMakeLists.txt <http://git.reviewboard.kde.org/r/105139/#comment11481> why do you actually keep the kwin internal name "tabbox"? Why don't you set a decent name. Be aware that the name tabbox has been set in 1999 because it's a box you use the tab key for. But today it's not like that any more or would you consider the Plasma Active's window switcher as something like "tabbox"? I really think in Plasmate we should not use historical names from KWin, but give proper names. previewer/tabbox/standalone/windowswitcherpreviewer.cpp <http://git.reviewboard.kde.org/r/105139/#comment11487> should that be i18n? previewer/tabbox/standalone/windowswitcherpreviewer.cpp <http://git.reviewboard.kde.org/r/105139/#comment11486> i18n missing previewer/tabbox/standalone/windowswitcherpreviewer.cpp <http://git.reviewboard.kde.org/r/105139/#comment11488> ? previewer/tabbox/standalone/windowswitcherpreviewer.cpp <http://git.reviewboard.kde.org/r/105139/#comment11485> please don't add additional new lines, just one new line at end of file previewer/tabbox/tabboxdelegate.qml <http://git.reviewboard.kde.org/r/105139/#comment11482> although if it's copied from KWin, the file is in Plasmate not part of KWin ;-) previewer/tabbox/windowswitcher.cpp <http://git.reviewboard.kde.org/r/105139/#comment11483> why are here commented includes? previewer/tabbox/windowswitcher.cpp <http://git.reviewboard.kde.org/r/105139/#comment11484> ? - Martin Gräßlin On June 6, 2012, 1:28 p.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105139/ > ----------------------------------------------------------- > > (Updated June 6, 2012, 1:28 p.m.) > > > Review request for kwin, Plasma and Martin Gräßlin. > > > Description > ------- > > Hello, > > This is the second task of my GSoC.Everything seems to work execpt from: > > 1)The icon of the refresh (in the tabbox previewer) is not visible. > 2)I couldn't try if the refresh works... > > > This addresses bug master. > http://bugs.kde.org/show_bug.cgi?id=master > > > Diffs > ----- > > CMakeLists.txt 12f8a3a > mainwindow.cpp 6f72624 > previewer/tabbox/standalone/main.cpp PRE-CREATION > previewer/tabbox/standalone/windowswitcherpreviewer.h PRE-CREATION > previewer/tabbox/standalone/windowswitcherpreviewer.cpp PRE-CREATION > previewer/tabbox/tabboxdelegate.qml PRE-CREATION > previewer/tabbox/tabboxpreviewer.h PRE-CREATION > previewer/tabbox/tabboxpreviewer.cpp PRE-CREATION > previewer/tabbox/thumbnailitem.h PRE-CREATION > previewer/tabbox/thumbnailitem.cpp PRE-CREATION > previewer/tabbox/thumbnails/dolphin.png PRE-CREATION > previewer/tabbox/thumbnails/kmail.png PRE-CREATION > previewer/tabbox/thumbnails/konqueror.png PRE-CREATION > previewer/tabbox/thumbnails/systemsettings.png PRE-CREATION > previewer/tabbox/windowswitcher.h PRE-CREATION > previewer/tabbox/windowswitcher.cpp PRE-CREATION > startpage.cpp 9774b48 > > Diff: http://git.reviewboard.kde.org/r/105139/diff/ > > > Testing > ------- > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/105139/s/590/ > > > Thanks, > > Antonis Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
