Re: Review Request: Launcher support for libtaskmanager

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4585/#review7215 --- Ship it! looks good :) let's get this into svn and then see about add

Re: Review Request: Launcher support for libtaskmanager

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4585/ --- (Updated 2010-08-25 18:12:01.192415) Review request for Plasma. Changes --

Re: Review Request: Launcher support for libtaskmanager

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4585/ --- (Updated 2010-08-25 17:59:38.336993) Review request for Plasma. Changes --

Re: Review Request: Launcher support for libtaskmanager

> On 2010-07-13 20:53:40, Aaron Seigo wrote: > > /trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp, lines 264-269 > > > > > > why are launchers with no window instances removed from the member list? > > Anton K

Re: Review Request: Launcher support for libtaskmanager

> On 2010-07-13 20:53:40, Aaron Seigo wrote: > > /trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp, lines 264-269 > > > > > > why are launchers with no window instances removed from the member list? > > Anton K

Re: Review Request: Launcher support for libtaskmanager

> On 2010-07-13 20:53:40, Aaron Seigo wrote: > > /trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp, lines 264-269 > > > > > > why are launchers with no window instances removed from the member list? > > Anton K

Re: Review Request: Launcher support for libtaskmanager

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4585/#review7175 --- /trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp

Re: Review Request: Launcher support for libtaskmanager

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4585/ --- (Updated 2010-08-22 10:39:29.599662) Review request for Plasma. Changes --

Re: Review Request: Launcher support for libtaskmanager

> On 2010-07-13 20:53:40, Aaron Seigo wrote: > > /trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp, lines 264-269 > > > > > > why are launchers with no window instances removed from the member list? isVisible()

Re: Review Request: Launcher support for libtaskmanager

On Tuesday 13 July 2010, Aaron Seigo wrote: > > On 2010-07-10 19:13:13, Markus Slopianka wrote: > > > GPL for library files? Sounds strange to me. I'd expect at least > > > LGPL... > > > > Marco Martin wrote: > > this library is a big mess it already contains pieces in gpl, lgpl > > and bs

Re: Review Request: Launcher support for libtaskmanager

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4585/#review6545 --- /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.h

Re: Review Request: Launcher support for libtaskmanager

> On 2010-07-10 19:13:13, Markus Slopianka wrote: > > GPL for library files? Sounds strange to me. I'd expect at least LGPL... > > Marco Martin wrote: > this library is a big mess it already contains pieces in gpl, lgpl and bsd > this really should be fixed > > Markus Slopianka wrote: >

Re: Review Request: Launcher support for libtaskmanager

> On 2010-07-10 19:13:13, Markus Slopianka wrote: > > GPL for library files? Sounds strange to me. I'd expect at least LGPL... > > Marco Martin wrote: > this library is a big mess it already contains pieces in gpl, lgpl and bsd > this really should be fixed Combining LGPL and more permi

Re: Review Request: Launcher support for libtaskmanager

> On 2010-07-10 19:13:13, Markus Slopianka wrote: > > GPL for library files? Sounds strange to me. I'd expect at least LGPL... this library is a big mess it already contains pieces in gpl, lgpl and bsd this really should be fixed - Marco --

Re: Review Request: Launcher support for libtaskmanager

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4585/#review6469 --- Um, I think that was done by accident: /kdebase/workspace/libs/taskman

Re: Review Request: Launcher support for libtaskmanager

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4585/#review6471 --- GPL for library files? Sounds strange to me. I'd expect at least LGPL.

Re: Review Request: Launcher support for libtaskmanager

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4585/ --- (Updated 2010-07-10 18:21:39.521058) Review request for Plasma. Changes --

Re: Review Request: Launcher support for libtaskmanager

> On 2010-07-10 18:05:01, Markus Slopianka wrote: > > Um, I think that was done by accident: > > /kdebase/workspace/libs/taskmanager/launcheritem.h is GPL while > > /kdebase/workspace/libs/taskmanager/launcheritem.cpp is under a BSD license. > > > > Shouldn't both be BSDL'ed? You're right, it'

Re: Review Request: Launcher support for libtaskmanager

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4585/ --- (Updated 2010-07-10 17:21:34.119645) Review request for Plasma. Summary --