----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4585/#review7215 -----------------------------------------------------------
Ship it! looks good :) let's get this into svn and then see about adding support to the tasks widget for launchers. - Aaron On 2010-08-25 18:12:01, Anton Kreuzkamp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4585/ > ----------------------------------------------------------- > > (Updated 2010-08-25 18:12:01) > > > Review request for Plasma. > > > Summary > ------- > > Adds support for Windows 7 like launchers in libtaskmanager. > (I'm on holliday from 12th July until 1st August so I will not be able to > reply during this time.) > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/libs/taskmanager/CMakeLists.txt 1148442 > /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.h > 1148442 > /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.cpp > 1148442 > /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupingstrategy.h > 1148442 > /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupingstrategy.cpp > 1148442 > /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractsortingstrategy.cpp > 1148442 > /trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.h 1148442 > /trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp 1148442 > /trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.h PRE-CREATION > /trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.cpp PRE-CREATION > > /trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/alphasortingstrategy.cpp > 1148442 > > /trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/kustodiangroupingstrategy.cpp > 1148442 > > /trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/manualgroupingstrategy.cpp > 1148442 > > /trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/programgroupingstrategy.cpp > 1148442 > /trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions.cpp 1148442 > /trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.h 1166310 > /trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp 1166310 > /trunk/KDE/kdebase/workspace/libs/taskmanager/taskitem.h 1166310 > /trunk/KDE/kdebase/workspace/libs/taskmanager/taskitem.cpp 1148442 > > Diff: http://reviewboard.kde.org/r/4585/diff > > > Testing > ------- > > Tested with a small test-applett and everything works. > Edit: In "GroupManagerPrivate::removeTask(TaskPtr task)" the method > "task->classClass()"(l.326) returns an empty string (in > "GroupManagerPrivate::addTask(TaskPtr task)" the method > "item->task()->classClass()"(l.289) works just fine), so Launchers don't get > showed again after quitting the application. > > > Thanks, > > Anton > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
