> On 2010-07-10 19:13:13, Markus Slopianka wrote: > > GPL for library files? Sounds strange to me. I'd expect at least LGPL... > > Marco Martin wrote: > this library is a big mess it already contains pieces in gpl, lgpl and bsd > this really should be fixed
Combining LGPL and more permissive licenses (BSD, MIT) isn't such a big deal, but I'd avoid GPL for libraries. While it's not a violation of KDE's Licensing Policies (that one only demands LGPL or more permissive for kdelibs, kdepimlibs and kdebase-runtime), it's at least inconsistent with KDE's general "LGPL for libraries and GPL for applications" approach. I suggest to Anton to use LGPL for both to at least make the situation not more messy than it already is. - Markus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4585/#review6471 ----------------------------------------------------------- On 2010-07-10 18:21:39, Anton Kreuzkamp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4585/ > ----------------------------------------------------------- > > (Updated 2010-07-10 18:21:39) > > > Review request for Plasma. > > > Summary > ------- > > Adds support for Windows 7 like launchers in libtaskmanager. > (I'm on holliday from 12th July until 1st August so I will not be able to > reply during this time.) > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/libs/taskmanager/taskitem.h 1148442 > /trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp 1148442 > /trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.h 1148442 > > /trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/programgroupingstrategy.cpp > 1148442 > /trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.cpp PRE-CREATION > /trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.h PRE-CREATION > /trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp 1148442 > /trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.h 1148442 > /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.h > 1148442 > /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractsortingstrategy.cpp > 1148442 > /trunk/KDE/kdebase/workspace/libs/taskmanager/CMakeLists.txt 1148442 > > Diff: http://reviewboard.kde.org/r/4585/diff > > > Testing > ------- > > Tested with a small test-applett and everything works. > > > Thanks, > > Anton > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
