Re: Review Request: LCD Weather Station QML port

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106226/#review18265 --- This review has been submitted with commit d6b07b4ced4cd64f65e

Re: Review Request: LCD Weather Station QML port

> On Aug. 29, 2012, 12:22 a.m., Luis Gabriel Lima wrote: > > applets/weatherstation/package/contents/ui/LCDDisplay.qml, line 74 > > > > > > I still think we should keep as it is now to make the text color > > consis

Re: Review Request: LCD Weather Station QML port

> On Aug. 29, 2012, 12:22 a.m., Luis Gabriel Lima wrote: > > applets/weatherstation/package/contents/ui/LCDDisplay.qml, line 74 > > > > > > I still think we should keep as it is now to make the text color > > consis

Re: Review Request: LCD Weather Station QML port

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106226/#review18201 --- applets/weatherstation/package/contents/ui/LCDDisplay.qml

Re: Review Request: LCD Weather Station QML port

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106226/#review18125 --- Ship it! apart the hardcoded text color that should be correct

Re: Review Request: LCD Weather Station QML port

> On Aug. 27, 2012, 12:59 p.m., Sebastian Kügler wrote: > > applets/weatherstation/package/contents/ui/LCDDisplay.qml, line 74 > > > > > > Why not use theme here, if we don't have a fixed background anyway? > > Luis

Re: Review Request: LCD Weather Station QML port

> On Aug. 27, 2012, 9:14 a.m., Martin Klapetek wrote: > > Compared visually (haven't looked at the code), it looks fantastic. Just > > one question - should the new plasmoid also have the "LCD" background? It > > can be seen on the older one, the green-grayish-LCD-like-background, which > > is

Re: Review Request: LCD Weather Station QML port

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106226/ --- (Updated Aug. 27, 2012, 3:52 p.m.) Review request for Plasma and Marco Mar

Re: Review Request: LCD Weather Station QML port

> On Aug. 27, 2012, 9:14 a.m., Martin Klapetek wrote: > > Compared visually (haven't looked at the code), it looks fantastic. Just > > one question - should the new plasmoid also have the "LCD" background? It > > can be seen on the older one, the green-grayish-LCD-like-background, which > > is

Re: Review Request: LCD Weather Station QML port

> On Aug. 27, 2012, 12:59 p.m., Sebastian Kügler wrote: > > applets/weatherstation/package/contents/ui/LCDDisplay.qml, line 74 > > > > > > Why not use theme here, if we don't have a fixed background anyway? But we a

Re: Review Request: LCD Weather Station QML port

> On Aug. 27, 2012, 9:14 a.m., Martin Klapetek wrote: > > Compared visually (haven't looked at the code), it looks fantastic. Just > > one question - should the new plasmoid also have the "LCD" background? It > > can be seen on the older one, the green-grayish-LCD-like-background, which > > is

Re: Review Request: LCD Weather Station QML port

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106226/#review18088 --- applets/weatherstation/package/contents/ui/LCDDisplay.qml

Re: Review Request: LCD Weather Station QML port

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106226/#review18079 --- Compared visually (haven't looked at the code), it looks fantas

Re: Review Request: LCD Weather Station QML port

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106226/ --- (Updated Aug. 26, 2012, 8:06 p.m.) Review request for Plasma and Marco Mar