> On Aug. 27, 2012, 9:14 a.m., Martin Klapetek wrote: > > Compared visually (haven't looked at the code), it looks fantastic. Just > > one question - should the new plasmoid also have the "LCD" background? It > > can be seen on the older one, the green-grayish-LCD-like-background, which > > is missing in the new plasmoid. IMHO the background should stay to keep the > > visual parity.
The LCD background is still there as you can see in the first screenshot. - Luis Gabriel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106226/#review18079 ----------------------------------------------------------- On Aug. 26, 2012, 8:06 p.m., Luis Gabriel Lima wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106226/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2012, 8:06 p.m.) > > > Review request for Plasma and Marco Martin. > > > Description > ------- > > This patch is part of the work done in my GSoC 2012 project and contains the > new version of the LCD Weather Station plasmoid. > > > Diffs > ----- > > applets/weatherstation/CMakeLists.txt 748de4a > applets/weatherstation/lcd.svgz 7f5f3d3 > applets/weatherstation/lcd2.svgz PRE-CREATION > applets/weatherstation/lcd_digits.svgz PRE-CREATION > applets/weatherstation/package/contents/ui/LCDDigit.qml PRE-CREATION > applets/weatherstation/package/contents/ui/LCDDisplay.qml PRE-CREATION > applets/weatherstation/package/contents/ui/Wind.qml PRE-CREATION > applets/weatherstation/package/contents/ui/main.qml PRE-CREATION > applets/weatherstation/package/metadata.desktop PRE-CREATION > applets/weatherstation/weather_icons.svgz PRE-CREATION > applets/weatherstation/weatherstation.h 6d4ae24 > applets/weatherstation/weatherstation.cpp 8ada9c2 > applets/weatherstation/wind_arrows.svgz PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/106226/diff/ > > > Testing > ------- > > - Tested inside panels and floating on desktop > - Tested with various providers and locations > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/106226/s/701/ > > http://git.reviewboard.kde.org/r/106226/s/702/ > > > Thanks, > > Luis Gabriel Lima > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
