> On Aug. 27, 2012, 12:59 p.m., Sebastian Kügler wrote: > > applets/weatherstation/package/contents/ui/LCDDisplay.qml, line 74 > > <http://git.reviewboard.kde.org/r/106226/diff/1/?file=81359#file81359line74> > > > > Why not use theme here, if we don't have a fixed background anyway? > > Luis Gabriel Lima wrote: > But we also have the same fixed background as the previous C++ version.
yeah, should be theme.textcolor. it /may* be that some old themes with weird assumptions could get broken there but is mostly their problem - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106226/#review18088 ----------------------------------------------------------- On Aug. 27, 2012, 3:52 p.m., Luis Gabriel Lima wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106226/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2012, 3:52 p.m.) > > > Review request for Plasma and Marco Martin. > > > Description > ------- > > This patch is part of the work done in my GSoC 2012 project and contains the > new version of the LCD Weather Station plasmoid. > > > Diffs > ----- > > applets/weatherstation/CMakeLists.txt 748de4a > applets/weatherstation/lcd.svgz 7f5f3d3 > applets/weatherstation/lcd2.svgz PRE-CREATION > applets/weatherstation/lcd_digits.svgz PRE-CREATION > applets/weatherstation/package/contents/ui/LCDDigit.qml PRE-CREATION > applets/weatherstation/package/contents/ui/LCDDisplay.qml PRE-CREATION > applets/weatherstation/package/contents/ui/Wind.qml PRE-CREATION > applets/weatherstation/package/contents/ui/main.qml PRE-CREATION > applets/weatherstation/package/metadata.desktop PRE-CREATION > applets/weatherstation/weather_icons.svgz PRE-CREATION > applets/weatherstation/weatherstation.h 6d4ae24 > applets/weatherstation/weatherstation.cpp 8ada9c2 > applets/weatherstation/wind_arrows.svgz PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/106226/diff/ > > > Testing > ------- > > - Tested inside panels and floating on desktop > - Tested with various providers and locations > > > Screenshots > ----------- > > LCD background > http://git.reviewboard.kde.org/r/106226/s/701/ > No background > http://git.reviewboard.kde.org/r/106226/s/702/ > > > Thanks, > > Luis Gabriel Lima > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
