Re: Review Request: Comic applet using Plasma::Widgets

On Tuesday 10 March 2009, Matthias Fuchs wrote: > On Dienstag 10 März 2009 16:47:08 Aaron J. Seigo wrote: > > On Friday 06 March 2009, you wrote: > > > > On 2009-03-02 11:46:24, Aaron Seigo wrote: > > > > > looks good... > > > > > > > > > > on a semi-related note, i really think offering a configur

Re: Review Request: Comic applet using Plasma::Widgets

On Dienstag 10 März 2009 16:47:08 Aaron J. Seigo wrote: > On Friday 06 March 2009, you wrote: > > > On 2009-03-02 11:46:24, Aaron Seigo wrote: > > > > looks good... > > > > > > > > on a semi-related note, i really think offering a configuration > > > > option for the style of arrows is a mistake. t

Re: Review Request: Comic applet using Plasma::Widgets

> On 2009-03-02 11:46:24, Aaron Seigo wrote: > > looks good... > > > > on a semi-related note, i really think offering a configuration option for > > the style of arrows is a mistake. the arrows on hover is much more in the > > spirit of Plasma and the graphics for them look so much better. it

Re: Review Request: Comic applet using Plasma::Widgets

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/145/#review328 --- Ship it! looks good... on a semi-related note, i really think offering

Re: Review Request: Comic applet using Plasma::Widgets

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/145/ --- (Updated 2009-02-28 07:59:03.194514) Review request for Plasma. Changes ---

Re: Review Request: Comic applet using Plasma::Widgets

So is this good enough to be commited? Cheers! ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Comic applet using Plasma::Widgets

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/145/ --- (Updated 2009-02-25 13:30:49.350947) Review request for Plasma. Changes ---

Re: Review Request: Comic applet using Plasma::Widgets

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/145/ --- (Updated 2009-02-25 04:36:47.924343) Review request for Plasma. Summary ---

Re: Review Request: Comic applet using Plasma::Widgets

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/145/ --- (Updated 2009-02-25 04:34:58.634432) Review request for Plasma. Changes ---

Re: Review Request: Comic applet using Plasma::Widgets

> On 2009-02-21 08:43:04, Aaron Seigo wrote: > > KDE/kdeplasma-addons/applets/comic/imagewidget.cpp, line 29 > > > > > > this should probably have setCacheMode(DeviceCoordinateCache) set on it > > for performance purposes. So

Re: Review Request: Comic applet using Plasma::Widgets (not working yet)

> On 2009-02-21 10:40:17, Aaron Seigo wrote: > > /trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp, line 173 > > > > > > you probably want to add some stretch to the first (0) column, > > otherwise with column 1 sitting the

Re: Review Request: Comic applet using Plasma::Widgets (not working yet)

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/145/#review218 --- /trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp

Re: Review Request: Comic applet using Plasma::Widgets (not working yet)

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/145/ --- (Updated 2009-02-21 08:47:25.861570) Review request for Plasma. Changes ---

Re: Review Request: Comic applet using Plasma::Widgets (not working yet)

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/145/#review216 --- hard to say without seeing the comic.cpp part of the patch, which r-b is