> On 2009-02-21 08:43:04, Aaron Seigo wrote: > > KDE/kdeplasma-addons/applets/comic/imagewidget.cpp, line 29 > > <http://reviewboard.kde.org/r/145/diff/1/?file=938#file938line29> > > > > this should probably have setCacheMode(DeviceCoordinateCache) set on it > > for performance purposes.
Sometimes the image (after setImage) is not rerendered. What to do to avoid that? - Matthias ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/145/#review216 ----------------------------------------------------------- On 2009-02-25 04:34:58, Matthias Fuchs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/145/ > ----------------------------------------------------------- > > (Updated 2009-02-25 04:34:58) > > > Review request for Plasma. > > > Summary > ------- > > I converted the comic applet to use Plasma::Widgets and basically everything > works nice. > > I have some questions though: > > * Is there a way to avoid recreating the layout (ComicApplet::createLayout() > in this case )? > * Is there a way to add SpacerItems, so that mLabelId would be on the left of > bottomLayout and only use as much space as needed, while mLabelUrl would be > on the right and only use as much space needed as well? > > > Diffs > ----- > > KDE/kdeplasma-addons/applets/comic/CMakeLists.txt 930543 > KDE/kdeplasma-addons/applets/comic/arrowwidget.h PRE-CREATION > KDE/kdeplasma-addons/applets/comic/arrowwidget.cpp PRE-CREATION > KDE/kdeplasma-addons/applets/comic/comic.h 930543 > KDE/kdeplasma-addons/applets/comic/comic.cpp 930543 > KDE/kdeplasma-addons/applets/comic/imagewidget.h PRE-CREATION > KDE/kdeplasma-addons/applets/comic/imagewidget.cpp PRE-CREATION > > Diff: http://reviewboard.kde.org/r/145/diff > > > Testing > ------- > > Works fine. > > > Thanks, > > Matthias > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
