----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/145/#review216 -----------------------------------------------------------
hard to say without seeing the comic.cpp part of the patch, which r-b is currently saying it can't do :) can you try to upload a new version of your patch to see if r-b gets it right this time? KDE/kdeplasma-addons/applets/comic/imagewidget.cpp <http://reviewboard.kde.org/r/145/#comment118> this should probably have setCacheMode(DeviceCoordinateCache) set on it for performance purposes. KDE/kdeplasma-addons/applets/comic/imagewidget.cpp <http://reviewboard.kde.org/r/145/#comment119> just as a matter of style, i personally find it easier to read if instead of if (!something) { code1 } else { code2 } it's written as if (something) { code2 } else { code1 } :) KDE/kdeplasma-addons/applets/comic/imagewidget.cpp <http://reviewboard.kde.org/r/145/#comment120> for performance purposes, the painting should probably be limited to option->exposedRect - Aaron On 2009-02-21 07:27:35, Matthias Fuchs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/145/ > ----------------------------------------------------------- > > (Updated 2009-02-21 07:27:35) > > > Review request for Plasma. > > > Summary > ------- > > I am trying to use the Plasma Widgets in the comic applet instead of painting > everything. After several failed tries I beg you for help. > > The version you see here is one of my early attempts -- so not really cleaned > up -- without features I implemented later, like having the scrollbars inside > the ImageWidget. That way the diff is a little smaller. > There is a problem though: If I choose to display the comics _not_ at their > original size it does not work as it should. > > Can someone give me a hint here? > > PS.: I'm not that experienced with Qt, so the problem might be trivial for > you to find. > > > Diffs > ----- > > KDE/kdeplasma-addons/applets/comic/CMakeLists.txt 924313 > KDE/kdeplasma-addons/applets/comic/comic.h 924382 > KDE/kdeplasma-addons/applets/comic/comic.cpp 924726 > KDE/kdeplasma-addons/applets/comic/imagewidget.h PRE-CREATION > KDE/kdeplasma-addons/applets/comic/imagewidget.cpp PRE-CREATION > > Diff: http://reviewboard.kde.org/r/145/diff > > > Testing > ------- > > Works more or less when "Actual Size" is ticked, but not if that is _not_ the > case see screenshot. > > > Screenshots > ----------- > > "Actual Size" not ticked > http://reviewboard.kde.org/r/145/s/24/ > > > Thanks, > > Matthias > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
