Re: Plasma::Svg and performance

2008-10-16 Thread Aaron J. Seigo
On Thursday 16 October 2008, Marco Martin wrote: > uhm, i think it's right at least how findInRectsCache work, because right > now it returns false only when we are sure the element does not exist, so > when is true and the rect not valid is still to be checked... > i know it's not intuitive, but d

Re: Plasma::Svg and performance

2008-10-16 Thread Marco Martin
On Thursday 16 October 2008, Aaron J. Seigo wrote: > On Wednesday 15 October 2008, Marco Martin wrote: > > On Wednesday 15 October 2008, Aaron J. Seigo wrote: > > > On Wednesday 15 October 2008, Marco Martin wrote: > > > > with a kconfigroup? would make sense? > > > > > > it's the easy answer, so i

Re: Plasma::Svg and performance

2008-10-15 Thread Aaron J. Seigo
On Wednesday 15 October 2008, Marco Martin wrote: > On Wednesday 15 October 2008, Aaron J. Seigo wrote: > > On Wednesday 15 October 2008, Marco Martin wrote: > > > with a kconfigroup? would make sense? > > > > it's the easy answer, so i'd say: "let's go for it". > > > > we can benchmark it once it

Re: Plasma::Svg and performance

2008-10-15 Thread Marco Martin
On Wednesday 15 October 2008, Aaron J. Seigo wrote: > On Wednesday 15 October 2008, Marco Martin wrote: > > with a kconfigroup? would make sense? > > it's the easy answer, so i'd say: "let's go for it". > > we can benchmark it once it is in place and working. changing the cache > implementation wil

Re: Plasma::Svg and performance

2008-10-15 Thread Aaron J. Seigo
On Wednesday 15 October 2008, Jamboarder wrote: > > From: Aaron J. Seigo <[EMAIL PROTECTED]> > > > >> setImagePath (if the path is different that the current one) > > > > this only affects Plasma::SharedSvgRenderer usage, and is local to any > > given Plasma::Svg object. > > Might the pixmap cache

Re: Plasma::Svg and performance

2008-10-15 Thread Aaron J. Seigo
On Wednesday 15 October 2008, Riccardo Iaconelli wrote: > On Wednesday 15 October 2008 17:58:51 Jamboarder wrote: > > Should a clear/refresh be triggered if the path hasn't changed but the > > actual file has? > > Yes, I think so. Is a file watcher expensive? not really .. > Can't we simply use o

Re: Plasma::Svg and performance

2008-10-15 Thread Aaron J. Seigo
On Wednesday 15 October 2008, Marco Martin wrote: > with a kconfigroup? would make sense? it's the easy answer, so i'd say: "let's go for it". we can benchmark it once it is in place and working. changing the cache implementation will be an easy task after we have it there in the first place. i

Re: Plasma::Svg and performance

2008-10-15 Thread Jamboarder
> From: Aaron J. Seigo <[EMAIL PROTECTED]> >> setImagePath (if the path is different that the current one) > this only affects Plasma::SharedSvgRenderer usage, and is local to any given > Plasma::Svg object. Might the pixmap cache end up holding data for svg paths that are no longer being used b

Re: Plasma::Svg and performance

2008-10-15 Thread Marco Martin
On Wednesday 15 October 2008, Aaron J. Seigo wrote: > > > (maybe imited to a fixed number of > > elements say 100 to not make it grow forever) > > it will need to be a fixed size, yes, even without non-existent elements. > 100 is probably too small though. this isn't a huge amount of data, really.

Re: Plasma::Svg and performance

2008-10-15 Thread Riccardo Iaconelli
On Wednesday 15 October 2008 17:58:51 Jamboarder wrote: > Should a clear/refresh be triggered if the path hasn't changed but the > actual file has? Yes, I think so. Is a file watcher expensive? Can't we simply use one on the theme's SVGs here? Bye, -Riccardo -- GPG key: 3D0F6376 When encryptin

Re: Plasma::Svg and performance

2008-10-15 Thread Aaron J. Seigo
On Wednesday 15 October 2008, Jamboarder wrote: > > From: Aaron J. Seigo <[EMAIL PROTECTED]> > > one outstanding issue will be clearing the disk and parameter caches when > > the theme is updated on disk but not changed in the config. > > > > before i go any further with this approach: any thoughts

Re: Plasma::Svg and performance

2008-10-15 Thread Aaron J. Seigo
On Wednesday 15 October 2008, Marco Martin wrote: > ok, this patch is the idea, it seems to work, still has two problems dunno > how relevant: > -when checking for element existence it computes the rect, a bit of a > waste, but this way don't have to keep two separate caches for rect and for > exis

Re: Plasma::Svg and performance

2008-10-15 Thread Aaron J. Seigo
On Wednesday 15 October 2008, Alexis Ménard wrote: > I will try it...Some other parts like icons in the taskbar or in the pager > kill performance. (KIconLoarder takes forever) are you sure it's KIconLoader in that case? and do you have any numbers on the performance impact of them? -- Aaron J.

Re: Plasma::Svg and performance

2008-10-15 Thread Jamboarder
> From: Aaron J. Seigo <[EMAIL PROTECTED]> > one outstanding issue will be clearing the disk and parameter caches when the > theme is updated on disk but not changed in the config. > > before i go any further with this approach: any thoughts, ideas, inspirations? > It might be useful in general

Re: Plasma::Svg and performance

2008-10-15 Thread Marco Martin
On Wednesday 15 October 2008, Aaron J. Seigo wrote: > On Tuesday 14 October 2008, Aaron J. Seigo wrote: > > before i go any further with this approach: any thoughts, ideas, > > inspirations? > > i'd also be interested in people applying the patch locally and ensuring it > doesn't break anything for

Re: Plasma::Svg and performance

2008-10-15 Thread Marco Martin
On Wednesday 15 October 2008, Marco Martin wrote: > On Wednesday 15 October 2008, Aaron J. Seigo wrote: > > hi .. > > > > doing some profiling with valgrind/massif, i noticed that a large amount > > of start up processing and memory usage is spent in parsing SVGs. > > surprise! ;) > > > > i introdu

Re: Plasma::Svg and performance

2008-10-15 Thread Marco Martin
On Wednesday 15 October 2008, Alexis Ménard wrote: > I will try it...Some other parts like icons in the taskbar or in the pager > kill performance. (KIconLoarder takes forever) doesn't taskbar and pager use the pixmap coming from the windows as icons? > 2008/10/15 Aaron J. Seigo <[EMAIL PROTECTED]

Re: Plasma::Svg and performance

2008-10-15 Thread Marco Martin
On Wednesday 15 October 2008, Aaron J. Seigo wrote: > hi .. > > doing some profiling with valgrind/massif, i noticed that a large amount of > start up processing and memory usage is spent in parsing SVGs. surprise! ;) > > i introduced a KPixmapCache for on-disk caching to help prevent the need to >

Re: Plasma::Svg and performance

2008-10-15 Thread Alexis Ménard
I will try it...Some other parts like icons in the taskbar or in the pager kill performance. (KIconLoarder takes forever) 2008/10/15 Aaron J. Seigo <[EMAIL PROTECTED]> > On Tuesday 14 October 2008, Aaron J. Seigo wrote: > > before i go any further with this approach: any thoughts, ideas, > > insp

Re: Plasma::Svg and performance

2008-10-14 Thread Aaron J. Seigo
On Tuesday 14 October 2008, Aaron J. Seigo wrote: > before i go any further with this approach: any thoughts, ideas, > inspirations? i'd also be interested in people applying the patch locally and ensuring it doesn't break anything for them. SVG handling is obviously very key to plasma, so we ca

Plasma::Svg and performance

2008-10-14 Thread Aaron J. Seigo
hi .. doing some profiling with valgrind/massif, i noticed that a large amount of start up processing and memory usage is spent in parsing SVGs. surprise! ;) i introduced a KPixmapCache for on-disk caching to help prevent the need to render from the source SVG over and over. i was able to sque